Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Koen Martens <gmc@sonologic.nl>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/linuxconsoletools: bump version to 1.7.0
Date: Tue, 19 Nov 2019 07:42:11 +0100	[thread overview]
Message-ID: <20191119064211.GA32125@coltrane> (raw)
In-Reply-To: <20191118223939.13b3f725@windsurf.home>

On Mon, Nov 18, 2019 at 10:39:39PM +0100, Thomas Petazzoni wrote:
> On Sun, 17 Nov 2019 14:59:13 +0100
> Koen Martens <gmc@sonologic.nl> wrote:
> > This version changed the (optional) dependency from sdl and
> > sdl-config to sdl2 and pkg-config. Therefore, the patch that
> > provided the correct path to sdl-config has been dropped and
> > the dependency has been changed to BR2_PACKAGE_SDL2.
> > 
> > Somehow, SDL2 fails to build without shared library support,
> > but this is not explicitly depended on by SDL2, therefore
> > a dependency to BR2_SHARED_LIBS was added to the force-
> > feedback utility configuration option.
> > 
> > Signed-off-by: Koen Martens <gmc@sonologic.nl>
> > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> > ---
> >  .../linuxconsoletools/0002-sdl-config.patch   | 20 -------------------
> 
> Minor additional nit: ideally the commit log should explain why this
> patch is dropped.

It does, please read the first paragraph.

Koen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191119/cb32fa3e/attachment.asc>

  reply	other threads:[~2019-11-19  6:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-17 13:59 [Buildroot] [PATCH v2 1/1] package/linuxconsoletools: bump version to 1.7.0 Koen Martens
2019-11-18 21:38 ` Thomas Petazzoni
     [not found]   ` <20191119064433.GB32125@coltrane>
2019-11-19  8:12     ` Thomas Petazzoni
2019-11-19  9:49       ` Koen Martens
2019-11-19 20:01       ` Koen Martens
2019-11-18 21:39 ` Thomas Petazzoni
2019-11-19  6:42   ` Koen Martens [this message]
2019-11-19  8:10     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191119064211.GA32125@coltrane \
    --to=gmc@sonologic.nl \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox