From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/pkg-kconfig: fix reconfigure for kconfig packages
Date: Tue, 26 Nov 2019 14:58:37 +0100 [thread overview]
Message-ID: <20191126145837.3a28e202@windsurf> (raw)
In-Reply-To: <CA+_SqVYc-Rm3rw240LH37CVuZQaD6vt0iKvt=mQjeR4Pj3izug@mail.gmail.com>
On Tue, 26 Nov 2019 14:55:12 +0100
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
> > Instead of just reworking the commit message, I think it would instead
> > make sense to "git checkout 4b81badbcc0b25678ac6627548160702731cf393"
> > and test what was the behavior back then.
>
> Checked out at 4b81badbcc0b25678ac6627548160702731cf393
>
> $ make linux-reconfigure
> umask 0022 && make -C /home/angelo/DEV/BUILDROOT/buildroot
> O=/home/angelo/DEV/BUILDROOT/br_qemu_arm/. linux-reconfigure
> rm -f /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.stamp_staging_installed
> rm -f /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.stamp_target_installed
> rm -f /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.stamp_images_installed
> rm -f /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.stamp_host_installed
> rm -f /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.stamp_built
> rm -f /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.stamp_kconfig_fixup_done
> rm -f /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.stamp_configured
> /bin/sed -i -e "/\\<CONFIG_KERNEL_GZIP\\>/d"
> /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.config
> echo 'CONFIG_KERNEL_GZIP=y' >>
> /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.config
> /bin/sed -i -e "/\\<CONFIG_KERNEL_XZ\\>/d"
> /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.config
> echo '# CONFIG_KERNEL_XZ is not set' >>
> /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.config
> /bin/sed -i -e "/\\<CONFIG_CPU_LITTLE_ENDIAN\\>/d"
> /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.config
> echo 'CONFIG_CPU_LITTLE_ENDIAN=y' >>
> /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.config
> /bin/sed -i -e "/\\<CONFIG_AEABI\\>/d"
> /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.config
> echo 'CONFIG_AEABI=y' >>
> /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.config
> # As the kernel gets compiled before root filesystems are
> # built, we create a fake cpio file. It'll be
> # replaced later by the real cpio archive, and the kernel will be
> # rebuilt using the linux-rebuild-with-initramfs target.
> /bin/sed -i -e "/\\<CONFIG_DEVTMPFS\\>/d"
> /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.config
> echo 'CONFIG_DEVTMPFS=y' >>
> /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.config
> /bin/sed -i -e "/\\<CONFIG_DEVTMPFS_MOUNT\\>/d"
> /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.config
> echo 'CONFIG_DEVTMPFS_MOUNT=y' >>
> /home/angelo/DEV/BUILDROOT/br_qemu_arm/build/linux-4.7/.config
> scripts/kconfig/conf --olddefconfig Kconfig
So indeed, it only redoes the fixups, and does not regenerate the
.config from scratch. So there was no regression introduced later, it's
just that from the start, the -reconfigure behavior did not match what
the commit log said.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-11-26 13:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 12:24 [Buildroot] [PATCH v2] package/pkg-kconfig: fix reconfigure for kconfig packages Angelo Compagnucci
2019-11-26 13:18 ` Thomas Petazzoni
2019-11-26 13:22 ` Angelo Compagnucci
2019-11-26 13:29 ` Thomas Petazzoni
2019-11-26 13:55 ` Angelo Compagnucci
2019-11-26 13:58 ` Thomas Petazzoni [this message]
2019-11-26 13:59 ` Angelo Compagnucci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126145837.3a28e202@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox