Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/glibc: install locale utility when nls is enabled
Date: Tue, 26 Nov 2019 22:35:03 +0100	[thread overview]
Message-ID: <20191126223503.58c9d9a4@gmx.net> (raw)
In-Reply-To: <20191126085541.2688-1-p.debruijn@unilogic.nl>

Hello Pascal,

On Tue, 26 Nov 2019 09:55:41 +0100, Pascal de Bruijn <p.debruijn@unilogic.nl> wrote:

> Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl>
> ---
>  package/glibc/Config.in | 2 +-
>  package/glibc/glibc.mk  | 3 +++
>  2 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/package/glibc/Config.in b/package/glibc/Config.in
> index 323767f..b8c2573 100644
> --- a/package/glibc/Config.in
> +++ b/package/glibc/Config.in
> @@ -14,7 +14,7 @@ config BR2_PACKAGE_GLIBC_UTILS
>  	depends on BR2_PACKAGE_BASH
>  	help
>  	  Enabling this option will compile and install the getconf,
> -	  ldconfig and ldd glibc utilities for the target.
> +	  ldconfig, ldd and locale glibc utilities for the target.
>
>  comment "glibc utilities need bash"
>  	depends on !BR2_PACKAGE_BASH
> diff --git a/package/glibc/glibc.mk b/package/glibc/glibc.mk
> index 5da0b06..e366134 100644
> --- a/package/glibc/glibc.mk
> +++ b/package/glibc/glibc.mk
> @@ -146,7 +146,10 @@ endif
>  ifeq ($(BR2_PACKAGE_GLIBC_UTILS),y)
>  GLIBC_TARGET_UTILS_USR_BIN = posix/getconf elf/ldd
>  GLIBC_TARGET_UTILS_SBIN = elf/ldconfig
> +endif
>
> +ifeq ($(BR2_SYSTEM_ENABLE_NLS),y)
> +GLIBC_TARGET_UTILS_USR_BIN += locale/locale
>  endif

Short question regarding your patch: Why install the locale command
only in case BR2_SYSTEM_ENABLE_NLS is enabled?

Background: The postgresql initialize startup script emits the following
warning:

	performing post-bootstrap initialization ... sh: locale: not found
	1970-01-01 00:10:13.173 UTC [398] WARNING:  no usable system locales were found

Which can be fixed by:

  - install the locale command (fixes 'sh: locale: not found')
  - enabling some locales e.g. by BR2_GENERATE_LOCALE="C en_US" (fixes no usable system locales were found)

No need to enable BR2_SYSTEM_ENABLE_NLS...

Regards,
Peter

>
>  define GLIBC_INSTALL_TARGET_CMDS

      parent reply	other threads:[~2019-11-26 21:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26  8:55 [Buildroot] [PATCH] package/glibc: install locale utility when nls is enabled Pascal de Bruijn
2019-11-26 11:52 ` Thomas Petazzoni
2019-11-26 21:35 ` Peter Seiderer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191126223503.58c9d9a4@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox