Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] Compiling Python packages with C extensions with per-package directories
Date: Sat, 30 Nov 2019 21:07:25 +0100	[thread overview]
Message-ID: <20191130210725.180ee73a@windsurf> (raw)
In-Reply-To: <CALFsTFVv0esYx0XKRLpRidTSu9sV1AmxT0n-A_GTNGEEuHWTxQ@mail.gmail.com>

Hello Asaf,

On Sat, 30 Nov 2019 21:20:05 +0200
Asaf Kahlon <asafka7@gmail.com> wrote:

> As now some work on per-package directories has been merged for the
> next release, I tried to play with it a little and encountered the
> following problem:
> When compiling a Python package with C sources, the compilation fails.

I have this patch:

  https://github.com/tpetazzoni/buildroot/commit/f2a92b1321bd0d63e5fad81b0cfc9ace910d17a0

which I believe should fix the problems you mention. My patch series
for per-package was just the core support. I have a number of
additional patches at
https://github.com/tpetazzoni/buildroot/commits/ppsh-v8-work that fix
some issues with per-package directories (but not all, of course).


> I don't think we want to tweak the _sysconfigdata file for every
> python package (although it would lead to a more "correct" situation,
> in which every sysroot contains _sysconfidata with proper paths).
> In addition, I wonder why do we need to copy all the toolchain-related
> files for every single package? (Maybe a symlink can help?)

We don't copy things for every single package, we do hard links. All
the per-package logic is based on making copy using hard links, so it
is very cheap.

My patch at
https://github.com/tpetazzoni/buildroot/commit/f2a92b1321bd0d63e5fad81b0cfc9ace910d17a0
indeed consists in tweaking the sysconfigdata on a per package basis.
Do not hesitate to let me know if you see any other solution. Ideally,
all the paths in sysconfigdata should be defined relatively to the
location of the sysconfidata file itself. I think I tried to do that
back then, but didn't succeed.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-11-30 20:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-30 19:20 [Buildroot] Compiling Python packages with C extensions with per-package directories Asaf Kahlon
2019-11-30 20:07 ` Thomas Petazzoni [this message]
2019-11-30 20:57   ` Asaf Kahlon
2019-11-30 21:27     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191130210725.180ee73a@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox