From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next v2 1/1] package/grpc: bump to version 1.25.0
Date: Tue, 3 Dec 2019 22:56:31 +0100 [thread overview]
Message-ID: <20191203215631.GA20811@scaer> (raw)
In-Reply-To: <20191128231803.1351294-1-aduskett@gmail.com>
Adam, All,
On 2019-11-28 15:18 -0800, aduskett at gmail.com spake thusly:
> From: Adam Duskett <Aduskett@gmail.com>
>
> Other changes:
> - Remove upstream patch 0004-Fix-gettid-naming-conflict.patch
> - Remove upstream patch 0005-Rename-gettid-functions.patch
> - Add a check for BR2_TOOLCHAIN_GCC_AT_LEAST_5 in grpc.mk. If the selected
> toolchain is not at least version 5 or higher, set the GRPC_CFLAGS and
> GRPC_CXXFLAGS optimizations to -O0. This check prevents the following error:
> error: failure memory model cannot be stronger than success memory
> model for '__atomic_compare_exchange'
Also:
- since 1.24.0, gRPC now requires C++ for tiself, not only as
inherited from protobuf
[--SNIP--]
> diff --git a/package/grpc/grpc.mk b/package/grpc/grpc.mk
> index 569db12089..bc0bee10b1 100644
> --- a/package/grpc/grpc.mk
> +++ b/package/grpc/grpc.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -GRPC_VERSION = 1.23.0
> +GRPC_VERSION = 1.25.0
> GRPC_SITE = $(call github,grpc,grpc,v$(GRPC_VERSION))
> GRPC_LICENSE = Apache-2.0
> GRPC_LICENSE_FILES = LICENSE
> @@ -43,11 +43,19 @@ GRPC_CFLAGS += -DGPR_DISABLE_WRAPPED_MEMCPY
> GRPC_CXXFLAGS += -DGPR_DISABLE_WRAPPED_MEMCPY
> endif
>
> +# Toolchains older than gcc5 will fail to compile with -0s due to:
> +# error: failure memory model cannot be stronger than success memory model for
> +# '__atomic_compare_exchange'
This comment should got below, along with the gc-at-least condition, I
guess, no?
I've spawned a few tests to see if that bump could fix all the failures
I encounter on my autobuilder. I'll report back later.
Regards,
Yann E. MORIN.
> ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
> GRPC_CFLAGS += -O0
> GRPC_CXXFLAGS += -O0
> endif
>
> +ifneq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_5),y)
> +GRPC_CFLAGS += -O0
> +GRPC_CXXFLAGS += -O0
> +endif
> +
> GRPC_CONF_OPTS += \
> -DCMAKE_C_FLAGS="$(GRPC_CFLAGS)" \
> -DCMAKE_CXX_FLAGS="$(GRPC_CXXFLAGS)"
> --
> 2.23.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-12-03 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 23:18 [Buildroot] [PATCH/next v2 1/1] package/grpc: bump to version 1.25.0 aduskett at gmail.com
2019-12-03 21:56 ` Yann E. MORIN [this message]
2019-12-03 22:09 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203215631.GA20811@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox