Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/7] libnetconf2: adjust dependencies
Date: Wed, 4 Dec 2019 16:14:16 +0100	[thread overview]
Message-ID: <20191204161416.111467fc@windsurf> (raw)
In-Reply-To: <8c74f9fdebe7eef326420f5354f3ec8163930074.1575456104.git.jan.kundrat@cesnet.cz>

On Fri, 17 Mar 2017 19:29:53 +0100
Jan Kundr?t <jan.kundrat@cesnet.cz> wrote:

> This package needs at least one of these two options, or both:
> 
> - openssl
> - libssh + the server option
> 
> Without these, it is not possible to produce a usable library, so let's
> reflect this in the dependencies.
> 
> I'm not sure that there is so much value in this; I would actually
> prefer to have both of these unconditionally enabled, but the package is
> already done in this way, so be it.
> 
> Signed-off-by: Jan Kundr?t <jan.kundrat@cesnet.cz>
> ---
>  package/libnetconf2/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/libnetconf2/Config.in b/package/libnetconf2/Config.in
> index 0a735b5ed6..6d4c9c71d1 100644
> --- a/package/libnetconf2/Config.in
> +++ b/package/libnetconf2/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_LIBNETCONF2
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	depends on !BR2_STATIC_LIBS
>  	depends on BR2_USE_MMU
> +	depends on BR2_PACKAGE_LIBSSH_SERVER || BR2_PACKAGE_OPENSSL

If one of these is really mandatory for the package to work in any
meaningful way, then:

	select ONE_OPTION if !SECOND_OPTION

is preferred, so that it is more natural for users, and you don't need
the Config.in comment.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2019-12-04 15:14 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 10:41 [Buildroot] [PATCH 0/7] Improve sysrepo support Jan Kundrát
2019-12-04  9:05 ` [Buildroot] [PATCH 2/7] sysrepo: fix a typo when installing with systemd Jan Kundrát
2019-12-04 13:15   ` Heiko Thiery
2019-12-08 21:51   ` Thomas Petazzoni
2019-12-22 20:28   ` Peter Korsgaard
2019-12-04  9:35 ` [Buildroot] [PATCH 3/7] sysrepo: libnetconf2 is not needed Jan Kundrát
2019-12-04 13:07   ` Heiko Thiery
2019-12-08 21:57   ` Thomas Petazzoni
2019-12-22 20:29   ` Peter Korsgaard
2019-12-04  9:37 ` [Buildroot] [PATCH 4/7] sysrepo: Optional support for C++ bindings Jan Kundrát
2019-12-08 21:59   ` Thomas Petazzoni
2019-12-04  9:37 ` [Buildroot] [PATCH 5/7] sysrepo: Use a common repository location Jan Kundrát
2019-12-04 12:29   ` Heiko Thiery
2019-12-08 22:03   ` Thomas Petazzoni
2019-12-04 10:17 ` [Buildroot] [PATCH 7/7] Add me as a maintainer for the NETCONF stack Jan Kundrát
2019-12-08 22:04   ` Thomas Petazzoni
2019-12-22 20:29   ` Peter Korsgaard
2019-12-04 10:47 ` [Buildroot] [PATCH 1/7] libyang: Optional C++ bindings Jan Kundrát
2019-12-04 13:23   ` Heiko Thiery
2019-12-04 15:16   ` Thomas Petazzoni
2019-12-04 10:47 ` [Buildroot] [PATCH 6/7] libnetconf2: adjust dependencies Jan Kundrát
2019-12-04 12:53   ` Heiko Thiery
2019-12-04 13:00     ` Jan Kundrát
2019-12-04 13:11       ` Heiko Thiery
2019-12-04 15:14   ` Thomas Petazzoni [this message]
2019-12-08 22:05 ` [Buildroot] [PATCH 0/7] Improve sysrepo support Thomas Petazzoni
2019-12-08 22:11   ` Jan Kundrát

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191204161416.111467fc@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox