Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/arptables: bump to version 0.0.5
Date: Thu, 5 Dec 2019 23:00:36 +0100	[thread overview]
Message-ID: <20191205230036.60a49509@windsurf> (raw)
In-Reply-To: <20191204191144.2591797-1-fontaine.fabrice@gmail.com>

Hello,

+Yann, Arnout, Peter in Cc.

On Wed,  4 Dec 2019 20:11:44 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> diff --git a/package/arptables/Config.in b/package/arptables/Config.in
> index 873e791e81..aeb7250a72 100644
> --- a/package/arptables/Config.in
> +++ b/package/arptables/Config.in
> @@ -1,7 +1,12 @@
>  config BR2_PACKAGE_ARPTABLES
> -	bool "arptables"
> +	bool "arptables-legacy"

We normally want to have the package Config.in option name match the
package name, which would no longer be the case here.

>  	depends on BR2_USE_MMU # needs fork()
>  	help
> -	  Tool to set up, maintain, and inspect the tables of ARP rules.
> +	  Legacy tool to set up, maintain, and inspect the tables of ARP
> +	  rules.
>  
> -	  http://ebtables.sourceforge.net
> +	  A more uptodate client of the arptables tool is provided in
> +	  the iptables package. The new tool was formerly known as
> +	  arptables-compat.

Arnout, Peter, Yann, considering the change to the package, does it
make sense to rename it entirely to arptables-legacy ? Or should we
take Fabrice's approach, i.e keep the package name as-is, and just as
an exception change the option prompt ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-12-05 22:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 19:11 [Buildroot] [PATCH 1/1] package/arptables: bump to version 0.0.5 Fabrice Fontaine
2019-12-05 22:00 ` Thomas Petazzoni [this message]
2019-12-05 23:51   ` Arnout Vandecappelle
2019-12-06 22:45 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191205230036.60a49509@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox