From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Fri, 6 Dec 2019 09:01:43 +0100 Subject: [Buildroot] [PATCH 1/1] package/spidermonkey: depends on host gcc >= 4.9 In-Reply-To: <349fd5c7-0116-119d-e928-44cf004facc2@mind.be> References: <20191204214913.718567-1-aduskett@gmail.com> <20191205215828.7258d035@windsurf> <349fd5c7-0116-119d-e928-44cf004facc2@mind.be> Message-ID: <20191206090143.75788ff5@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Fri, 6 Dec 2019 00:02:44 +0100 Arnout Vandecappelle wrote: > > So what this patch seems to imply is that in fact gcc 4.9 is not really > > required by the spidermonkey code. If that's the case, then yes I > > believe having the patch is probably nicer than having to propagate the > > dependency. > > As I understand it, spidermonkey *does* use C++14 features (hence the need for > target GCC 4.9+). However, it also builds host tools which need only C++11 > features, but the test is applied to host and target compiler indiscriminately. > The patch doesn't make a correct distinction between host and target, it just > generally lowers the minimum C++ version. Ah, that's not good indeed. > Now, given that they assume C++14 support is available, it's relatively likely > that they'll start using those features in future versions. At that point. > things will anyway break and we need this condition. So I'd say, byte the bullet > now and require hsot and target GCC >= 4.9. Fair enough. We need to resurrect the patch then, because I changed its state to Changes Requested yesterday. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com