From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] package/xenomai: Smokey's not a skin
Date: Thu, 12 Dec 2019 21:48:20 +0100 [thread overview]
Message-ID: <20191212214820.1c84b011@windsurf> (raw)
In-Reply-To: <f23ad7759ce2abdebafcf0464cf15145e163285b.1576176280.git.jan.kiszka@siemens.com>
On Thu, 12 Dec 2019 19:44:37 +0100
Jan Kiszka <jan.kiszka@siemens.com> wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> That's a testsuite tool.
>
> Rename XENOMAI_REMOVE_SKIN_LIST at this chance as it's cleaning
> libraries.
I am confused, aren't psos, rtai, uitron, vxworks and al. called
"skins" in the Xenomai speak ?
Ideally, this variable rename should be done in a separate patch, since
it's independent from the smokey option removal.
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> package/xenomai/Config.in | 5 -----
> package/xenomai/xenomai.mk | 23 ++++++++++-------------
> 2 files changed, 10 insertions(+), 18 deletions(-)
>
> diff --git a/package/xenomai/Config.in b/package/xenomai/Config.in
> index 83ba8ca162..0cb0b343de 100644
> --- a/package/xenomai/Config.in
> +++ b/package/xenomai/Config.in
> @@ -170,11 +170,6 @@ config BR2_PACKAGE_XENOMAI_RTAI_SKIN
> help
> This option allows to install the RTAI Xenomai skin
>
> -config BR2_PACKAGE_XENOMAI_SMOKEY_SKIN
> - bool "Smokey skin"
> - help
> - This option allows to install the Smokey Xenomai skin
We normally want to have Config.in.legacy handling when removing
options, but in this case, the options was in fact not really doing
anything useful, so I believe it's OK to just drop it like you did.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-12-12 20:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 18:44 [Buildroot] [PATCH 0/4] package/xenomai: Fixes, updates, enhancements Jan Kiszka
2019-12-12 18:44 ` [Buildroot] [PATCH 1/4] package/xenomai: Smokey's not a skin Jan Kiszka
2019-12-12 20:48 ` Thomas Petazzoni [this message]
2019-12-13 6:24 ` Jan Kiszka
2019-12-12 18:44 ` [Buildroot] [PATCH 2/4] package/xenomai: Pull from git Jan Kiszka
2019-12-12 20:52 ` Thomas Petazzoni
2019-12-13 6:32 ` Jan Kiszka
2019-12-12 18:44 ` [Buildroot] [PATCH 3/4] package/xenomai: Bump version to 3.0.10 Jan Kiszka
2019-12-12 18:44 ` [Buildroot] [PATCH 4/4] package/xenomai: Clean up wrappers cleanup Jan Kiszka
2019-12-12 20:45 ` [Buildroot] [PATCH 0/4] package/xenomai: Fixes, updates, enhancements Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212214820.1c84b011@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox