From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] SDL_mixer: Prefer Tremor over libvorbis
Date: Thu, 12 Dec 2019 21:54:32 +0100 [thread overview]
Message-ID: <20191212215432.33196aeb@windsurf> (raw)
In-Reply-To: <20191212171859.783617-1-paul@crapouillou.net>
Hello,
On Thu, 12 Dec 2019 18:18:59 +0100
Paul Cercueil <paul@crapouillou.net> wrote:
> When Tremor is enabled, configure SDL_mixer to use this Vorbis decoding
> library instead of libvorbis. Since Tremor does fixed-point math, it is
> safe to assume that if it's enabled then it is faster than libvorbis on
> the target architecture.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
The expected format/capitalization for the commit title is:
package/sdl_mixer: prefer tremor over libvorbis
> +ifeq ($(BR2_PACKAGE_TREMOR),y)
> +SDL_MIXER_CONF_OPTS += --enable-music-ogg-tremor
> +SDL_MIXER_DEPENDENCIES += tremor
> +else
> ifeq ($(BR2_PACKAGE_LIBVORBIS),y)
> SDL_MIXER_CONF_OPTS += --enable-music-ogg
> SDL_MIXER_DEPENDENCIES += libvorbis
> else
> SDL_MIXER_CONF_OPTS += --disable-music-ogg
> endif
> +endif
These conditions are better written like this:
ifeq ...
else ifeq ...
else ...
endif
Note how having the "ifeq" on the same line as the "else" avoids the
need for an additional "endif" at the end of condition.
I fixed both minor nits, and applied to master. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-12-12 20:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 17:18 [Buildroot] [PATCH v2] SDL_mixer: Prefer Tremor over libvorbis Paul Cercueil
2019-12-12 20:54 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212215432.33196aeb@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox