[Buildroot] [PATCH 02/12] package/pkg-utils.mk: add extractor-pkg-dependency macro

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

On Sat, 14 Dec 2019 22:20:21 +0100
Romain Naour <romain.naour@smile.fr> wrote:

> > diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> > index 0f916d81d8..35a441e0aa 100644
> > --- a/package/pkg-utils.mk
> > +++ b/package/pkg-utils.mk
> > @@ -46,6 +46,14 @@ INFLATE.tar  = cat
> >  # suitable-extractor(filename): returns extractor based on suffix
> >  suitable-extractor = $(INFLATE$(suffix $(1)))
> >    
> 
> What about gzip ?
> 
> EXTRACTOR_PKG_DEPENDENCY.gz   = $(BR2_GZIP_HOST_DEPENDENCY)
> EXTRACTOR_PKG_DEPENDENCY.tgz  = $(BR2_GZIP_HOST_DEPENDENCY)

Because oddly enough, we are today not taking into account  the
dependency on gzip when extracting tarballs.

We do take it into account only in:

ifneq ($$(filter cvs git svn,$$($(2)_SITE_METHOD)),)
$(2)_DOWNLOAD_DEPENDENCIES += \
        $(BR2_GZIP_HOST_DEPENDENCY) \
        $(BR2_TAR_HOST_DEPENDENCY)
endif

i.e, when we fetch from a version control system, and create our own
tarball locally.

But if we download directly from http/ftp a .tar.gz or .tgz, we don't
rely on BR2_GZIP_HOST_DEPENDENCY, and simply assume we can use the one
from the host machine.

This should be fixed, I agree, but it's already broken today I believe.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com