[Buildroot] [PATCH v2 2/3] package/mariadb: update startup scripts

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello,

On Sun, 15 Dec 2019 13:33:25 -0800
Ryan Coe <bluemrp9@gmail.com> wrote:

> The init scripts have been modified to create a directory under
> /var/log/mysql and specify mysqld to use it for logging. The directory
> test to call mysql_install_db has been redirected to /dev/null to prevent
> an error message from showing if /var/lib/mysql does not exist.
> 
> Signed-off-by: Ryan Coe <bluemrp9@gmail.com>

A commit title that says "update startup scripts" is a good hint that
the splitting of changes is not good. It hints that you're doing
several things at once in the same commit, which are unrelated to each
other.

There are (at least?) three independent changes here:

 - Redirection of stderr when listing $MYSQL_LIB

 - Rename of the MYSQL_PID variable

 - Move the logs to /var/log/mysql

Three independent changes should lead to three independent commits.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com