From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 00/13] use host-systemd to enable units
Date: Thu, 19 Dec 2019 17:50:14 +0100 [thread overview]
Message-ID: <20191219165014.GE26395@scaer> (raw)
In-Reply-To: <CAFvCimVGu5Bv3GFUmaQtkBjUHbWFoSbagCLsp3_Mb+yztJLH5g@mail.gmail.com>
J?r?my, All,
On 2019-12-19 14:50 +0100, J?r?my ROSEN spake thusly:
> Ok, my bad for having you work on it that much, I have still lot to learn about all?
> those conventions?
Well, what I did was mostly cosmetics, so that did not warrant a respin.
> One specific point I don't agree with below, but it's just a detail at this point
>
> 35c11a027c package/systemd: add host variant
> ? ? ? - reformatting in commit log
> ? ? ? - declare host variant after target variant
> ? ? ? - simplify comments
> ? ? ? - slight reordering of variable (HOST_SYSTEMD_NINJA_ENV moved)
> ? ? ? - reformatting for mutli-line variable (HOST_SYSTEMD_HOST_TOOLS)
> ? ? ? - don't split HOST_SYSTEMD_CONF_OPTS in two sets
>
> well, it's applied now, but I did that in a very specific way
> * Variables I specifically set were in the first set
> * Disabling all optional features was in the second set
> The point was to help maintainability.
We almost never do that in Buildroot (I was about to say 'never', but we
may or may not have a few cases), but overall, it is not needed. We only
do additive settings for those parts that are conditional, which is not
the case here.
Still, the two sets are properly separated, with all the =yes first, and
the =false last.
> Apart from that, nothing suspicious on my side
Thanks! :-)
Regards,
Yann E. MORIN.
> thx a lot
> --
>
> +---------------------------------------------------------------------------------------------------------------------+
> | | J?r?my ROSEN |
> | [1]3D"SMILE"[2] ? | Architecte technique |
> | | [3]3D"email" ? [4]jeremy.rosen at smile.fr? |
> | 20 rue des Jardins | [5]3D"phone" ? +33 6 88 25 87 42? |
> | 92600 Asni?res-sur-Seine | [6]3D"url" ? [7]http://www.smile.eu |
> | | [8]3D"Twitter" ? [9]3D"Facebook" ? [10]3D"LinkedIn" ? [11]3D"Github" |
> +---------------------------------------------------------------------------------------------------------------------+
>
> [12]3D"D?couvrez
>
> Links:
> 1. http://www.smile.eu/
> 2. http://www.smile.eu/
> 3. Image: http://ftp.smile.fr/client/Communication/signature/img/mail.png
> 4. mailto:jeremy.rosen at smile.fr
> 5. Image: http://ftp.smile.fr/client/Communication/signature/img/phone.png
> 6. Image: http://ftp.smile.fr/client/Communication/signature/img/web.png
> 7. http://www.smile.eu/
> 8. https://twitter.com/GroupeSmile
> 9. https://www.facebook.com/smileopensource
> 10. https://www.linkedin.com/company/smile
> 11. https://github.com/Smile-SA
> 12. https://www.smile.eu/fr/publications/livres-blancs/yocto?utm_source=signature&utm_medium=email&utm_campaign=signature
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2019-12-19 16:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 10:30 [Buildroot] [PATCH v5 00/13] use host-systemd to enable units Jérémy Rosen
2019-12-16 10:30 ` [Buildroot] [PATCH v5 01/13] package/systemd: add host variant Jérémy Rosen
2019-12-16 10:30 ` [Buildroot] [PATCH v5 02/13] package/systemd: use host-systemctl preset all to enable units Jérémy Rosen
2019-12-16 10:30 ` [Buildroot] [PATCH v5 03/13] package/systemd: fix tty handling Jérémy Rosen
2020-05-16 14:28 ` Thomas Petazzoni
2020-05-18 7:12 ` Jérémy ROSEN
2020-05-22 17:00 ` Jérémy ROSEN
2019-12-16 10:30 ` [Buildroot] [PATCH v5 04/13] package: rely on systemctl preset-all for buildroot-provided services Jérémy Rosen
2019-12-16 10:30 ` [Buildroot] [PATCH v5 05/13] package: rely on systemctl preset-all for upstream-provided services Jérémy Rosen
2019-12-16 10:30 ` [Buildroot] [PATCH v5 06/13] package/connman: adapt to systemctl preset-all Jérémy Rosen
2019-12-16 10:30 ` [Buildroot] [PATCH v5 07/13] package/linuxptp " Jérémy Rosen
2019-12-16 10:30 ` [Buildroot] [PATCH v5 08/13] package/network-manager: " Jérémy Rosen
2019-12-16 10:30 ` [Buildroot] [PATCH v5 09/13] package/wpa_supplicant: " Jérémy Rosen
2019-12-16 10:30 ` [Buildroot] [PATCH v5 10/13] package/sysrepo: " Jérémy Rosen
2019-12-16 10:30 ` [Buildroot] [PATCH v5 11/13] package/syslog-ng: implement systemd enablement using DefaultInstance Jérémy Rosen
2019-12-16 10:30 ` [Buildroot] [PATCH v5 12/13] package/rauc: add a WantedBy section to the systemd unit file Jérémy Rosen
2019-12-16 10:30 ` [Buildroot] [PATCH v5 13/13] package/alsa-utils: " Jérémy Rosen
2019-12-18 17:48 ` [Buildroot] [PATCH v5 00/13] use host-systemd to enable units Yann E. MORIN
2019-12-19 13:50 ` Jérémy ROSEN
2019-12-19 16:50 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219165014.GE26395@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox