From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/qt5/qt5webengine: fix build error
Date: Sat, 21 Dec 2019 22:35:54 +0100 [thread overview]
Message-ID: <20191221223554.4f36a4aa@windsurf> (raw)
In-Reply-To: <20191221111218.26960-1-b.bilas@grinn-global.com>
On Sat, 21 Dec 2019 12:12:18 +0100
Bartosz Bilas <b.bilas@grinn-global.com> wrote:
> This commit adds a patch from upstream chromium [1].
>
> Fixes:
> ../../3rdparty/chromium/third_party/skia/third_party/skcms/skcms.cc:1909:16:
> note: in definition of macro 'NS'
> #define NS(id) id
>
> [1] https://chromium.googlesource.com/chromium/src/+/a8c8396fd20d98666d517c45b358c63736e345ef
>
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> ---
> v1 -> v2:
> - keep gcc 4.8 as a minimum required version (suggested by Giulio Benetti)
> ..._config-Fixes-when-use_sysroot-false.patch | 57 +++++++++++++++++++
> 1 file changed, 57 insertions(+)
> create mode 100644 package/qt5/qt5webengine/5.12.5/0001-pkg_config-Fixes-when-use_sysroot-false.patch
Thanks! I've applied to master, after improving the commit log as
suggested from the first reply of Giulio.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-12-21 21:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 11:12 [Buildroot] [PATCH v2 1/1] package/qt5/qt5webengine: fix build error Bartosz Bilas
2019-12-21 18:24 ` Giulio Benetti
2019-12-21 18:26 ` Giulio Benetti
2019-12-21 21:37 ` Thomas Petazzoni
2019-12-21 21:45 ` giulio.benetti at benettiengineering.com
2019-12-21 21:35 ` Thomas Petazzoni [this message]
2019-12-25 18:07 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191221223554.4f36a4aa@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox