Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] package/genimage: add patch to support vfat volume-label
Date: Sun, 22 Dec 2019 21:57:35 +0100	[thread overview]
Message-ID: <20191222215735.7565a31c@windsurf> (raw)
In-Reply-To: <87pnggyunx.fsf@dell.be.48ers.dk>

On Sun, 22 Dec 2019 21:25:38 +0100
Peter Korsgaard <peter@korsgaard.com> wrote:

>  > Well, it's just a new feature that someone needs. We normally don't
>  > take feature patches, but this one is a backport from upstream.
>  > genimage also does new releases fairly infrequently, so waiting for the
>  > next release is not necessarily nice. The patch was short enough, taken
>  > directly from upstream, so I said "ok, let's take, it will anyway go
>  > away the next time we bump".  
> 
> OK, but we indeed don't take feature patches unless there is a good
> reason for it, and this commit is just syntactical sugar over adding -n
> <label> to extraargs, E.G.:
> 
> image foo.fat {
>   vfat {
>     extraargs = "-n MYLABEL"
>     ..
> }

True, I didn't know about extraargs. Really, I hesitated a bit because
of our usual policy, but then I said "meh, it's small, it's a backport
from upstream, let's not be too annoying". I can revert if needed, I
don't feel very strongly about this at all.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-12-22 20:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-21 21:22 [Buildroot] [git commit] package/genimage: add patch to support vfat volume-label Thomas Petazzoni
2019-12-22 15:01 ` Peter Korsgaard
2019-12-22 20:12   ` Thomas Petazzoni
2019-12-22 20:25     ` Peter Korsgaard
2019-12-22 20:57       ` Thomas Petazzoni [this message]
2019-12-22 21:05         ` Peter Korsgaard
2019-12-22 20:54     ` dariobin at libero.it

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191222215735.7565a31c@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox