From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] [PATCH] package/tio: new package
Date: Tue, 24 Dec 2019 14:14:51 +0100 [thread overview]
Message-ID: <20191224141451.521e9123@windsurf> (raw)
In-Reply-To: <20191223055102.lfw56utpgqalw2we@sapphire.tkos.co.il>
On Mon, 23 Dec 2019 07:51:02 +0200
Baruch Siach <baruch@tkos.co.il> wrote:
> > +TIO_LICENSE = GPLv2
>
> The LICENSE file has the "or any later version" language. Also, we prefer the
> SPDX license identifiers. So "GPL-2.0+".
Fixed when applying.
> > +TIO_LICENSE_FILES = COPYING
>
> Should also add "LICENSE".
There was no file named "LICENSE" in the source code, so I'm not sure
what your suggestion was. Did you suggest to add README instead maybe ?
Thanks for the review, it's definitely a lot easier when a well-known
contributor like you has reviewed a patch.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-12-24 13:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-22 22:12 [Buildroot] [PATCH] [PATCH] package/tio: new package Sergio Prado
2019-12-23 5:51 ` Baruch Siach
2019-12-24 13:14 ` Thomas Petazzoni [this message]
2019-12-24 13:38 ` Baruch Siach
2019-12-24 14:09 ` Thomas Petazzoni
2019-12-24 13:13 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191224141451.521e9123@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox