From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 25 Dec 2019 23:29:03 +0100 Subject: [Buildroot] [PATCH] package/lvm2: install udev rules In-Reply-To: <20191203090050.4382-1-p.debruijn@unilogic.nl> References: <20191203090050.4382-1-p.debruijn@unilogic.nl> Message-ID: <20191225232903.6325bb98@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Pascal, On Tue, 3 Dec 2019 10:00:50 +0100 Pascal de Bruijn wrote: > Without the device-mapper udev rules, dm devices will not get a proper > symlink like /dev/disk/by-label/LABEL, which in turn causes fstab > LABEL= mounts to fails. > > And by extension causes shenanigans with systemd, where it will > unmount a manually mounted disk because it can't resolve the label. > > Signed-off-by: Pascal de Bruijn > --- > package/lvm2/lvm2.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk > index 7fdb9a7..65576f4 100644 > --- a/package/lvm2/lvm2.mk > +++ b/package/lvm2/lvm2.mk > @@ -19,6 +19,7 @@ LVM2_CONF_OPTS += \ > --enable-pkgconfig \ > --enable-cmdlib \ > --enable-dmeventd \ > + --enable-udev_rules \ Why should this be done unconditionally ? Shouldn't instead this be: ifeq ($(BR2_PACKAGE_HAS_UDEV),y) LVM2_CONF_OPTS += --enable-udev_rules endif instead ? Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com