From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 1/1] package/ecryptfs-utils: fix parallel build
Date: Thu, 26 Dec 2019 16:10:08 +0100 [thread overview]
Message-ID: <20191226161008.7ee0166a@windsurf> (raw)
In-Reply-To: <20191226150330.3414899-1-fontaine.fabrice@gmail.com>
Hello Fabrice,
Thanks for the new iteration!
On Thu, 26 Dec 2019 16:03:30 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> diff --git a/package/ecryptfs-utils/0004-drop-AM_GLIB_GNU_GETTEXT.patch b/package/ecryptfs-utils/0004-drop-AM_GLIB_GNU_GETTEXT.patch
> new file mode 100644
> index 0000000000..0c8d0ec36e
> --- /dev/null
> +++ b/package/ecryptfs-utils/0004-drop-AM_GLIB_GNU_GETTEXT.patch
> @@ -0,0 +1,23 @@
> +drop AM_GLIB_GNU_GETTEXT
> +
> +This will fix the following failure when running autoreconf:
> +
> +configure.ac:372: warning: macro 'AM_GLIB_GNU_GETTEXT' not found in library
> +configure.ac:372: error: possibly undefined macro: AM_GLIB_GNU_GETTEXT
> + If this token and others are legitimate, please use m4_pattern_allow.
> + See the Autoconf documentation.
> +
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> +
> +diff -Nuar ecryptfs-utils-111-orig/configure.ac ecryptfs-utils-111/configure.ac
> +--- ecryptfs-utils-111-orig/configure.ac 2019-12-26 15:14:16.652146065 +0100
> ++++ ecryptfs-utils-111/configure.ac 2019-12-26 15:54:49.212246135 +0100
> +@@ -369,8 +369,6 @@
> + AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE,"$GETTEXT_PACKAGE",
> + [the gettext translation domain])
> +
> +-AM_GLIB_GNU_GETTEXT
Are you sure it is useless? Just dropping a line of code that is
"annoying" because it causes a build failure is quite weird.
What makes you think it is useless? This m4 macro is most likely
provided by some other package.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-12-26 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 15:03 [Buildroot] [PATCH v2, 1/1] package/ecryptfs-utils: fix parallel build Fabrice Fontaine
2019-12-26 15:10 ` Thomas Petazzoni [this message]
2019-12-26 15:34 ` Fabrice Fontaine
2019-12-26 16:14 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191226161008.7ee0166a@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox