Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [arc-buildroot] [PATCH] arch/arc: Explicitly set "max-page-size" for GNU LD
Date: Fri, 27 Dec 2019 16:43:20 +0100	[thread overview]
Message-ID: <20191227154320.GQ26395@scaer> (raw)
In-Reply-To: <CY4PR1201MB0120748B829AE787E4B3A097A12A0@CY4PR1201MB0120.namprd12.prod.outlook.com>

Alexey, All,

On 2019-12-27 09:00 +0000, Alexey Brodkin spake thusly:
[--SNIP--]
> > I was also contemplating a similar solution, but I was not too happy
> > with this trick to drop the suffix. I would have prefered something
> > like:
> > 
> >     config BR2_ARC_PAGE_SIZE_KB
> >         int
> >         default 4 if BR2_ARC_PAGE_SIZE_4K
> >         default 8 if BR2_ARC_PAGE_SIZE_8K
> >         default 16 if BR2_ARC_PAGE_SIZE_16K
> > 
> > and then:
> > 
> >     ARCH_TOOLCHAIN_WRAPPER_OPTS += -Wl,-z,max-page-size=$(shell echo $$(($(BR2_ARC_PAGE_SIZE)*1024)))
> > 
> > and in package/uclibc/uclibc.mk:
> > 
> >     UCLIBC_ARC_PAGE_SIZE = CONFIG_ARC_PAGE_SIZE_$(BR2_ARC_PAGE_SIZE)K
> > 
> > ... and even that intermediate variable could have been dropped
> > altogether, to directly write:
> > 
> >         $(call KCONFIG_ENABLE_OPT,CONFIG_ARC_PAGE_SIZE_$(BR2_ARC_PAGE_SIZE)K,$(@D)/.config)
> > 
> > And that would have been a bit nicer, I believe.
> 
> Agree. So, Yann [as usually] are you OK if I implement that improvement?

As you wish! ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2019-12-27 15:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-24 14:10 [Buildroot] [PATCH] arch/arc: Explicitly set "max-page-size" for GNU LD Alexey Brodkin
2019-12-25 21:36 ` Thomas Petazzoni
2019-12-26 17:05   ` Yann E. MORIN
2019-12-27  9:00     ` [Buildroot] [arc-buildroot] " Alexey Brodkin
2019-12-27 15:43       ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191227154320.GQ26395@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox