From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/ltp-testsuite: Replace libtirpc patch with simple removing files
Date: Mon, 30 Dec 2019 22:05:09 +0100 [thread overview]
Message-ID: <20191230210509.GA19473@dell5510> (raw)
In-Reply-To: <20191230205218.GV26395@scaer>
Hi Yann,
> On 2019-12-30 21:27 +0100, Petr Vorel spake thusly:
> > We delete files anyway, so let's use this way instead of applying patch.
> No, we prefer patches over hooks, and we've in the past replaced hooks
> that tweak/remove files with patches with the same effect.
Thanks for review and explain the policy.
> Besides, I'm pretty sure your patch is wrong, see below...
You right, I'm sorry to sent wrong patch.
I usually run validate patch, this time I didn't check. I'll be careful next
time.
> > Since libtirpc update to 1.2.5 commit message in patch was wrong anyway
> > (libtirpc patch 0005-Disable-DES-authentification-support.patch was
> > replaced by upstream solution).
> Then it is better to fix the description of the patch.
Sure. I'll wait whether upstream patch is accepted (if yes, I'll replace patch,
otherwise I fix the description).
Kind regards,
Petr
prev parent reply other threads:[~2019-12-30 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 20:27 [Buildroot] [PATCH 1/1] package/ltp-testsuite: Replace libtirpc patch with simple removing files Petr Vorel
2019-12-30 20:52 ` Yann E. MORIN
2019-12-30 21:05 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191230210509.GA19473@dell5510 \
--to=petr.vorel@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox