From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/gnupg: fix TAR path in gpg-zip script
Date: Mon, 30 Dec 2019 21:40:16 +0100 [thread overview]
Message-ID: <20191230214016.5b865216@windsurf> (raw)
In-Reply-To: <20191230132316.GQ26395@scaer>
On Mon, 30 Dec 2019 14:23:16 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > So we just opt with a very simple solution: replace TAR=something by
> > TAR=/bin/tar, through a post-install target hook. We only do this if
> > gpg-zip is installed, since its installation is optional. Note that
> > the logic is still not ideal, because the installation (or not) of
> > gpg-zip depends on whether the system/host tar has ustar format or
> > not.
>
> But isn't that always the case, in practice? If the host has
> 1.27 <= tar <= 1.29, then we use it, and that has support for ustar.
> Otherwise, we build tar 1.29, and that also has ustar.
That's true indeed. But it's still kind of a coincidence.
Thanks for reviewing and applying!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-12-30 20:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 22:14 [Buildroot] [PATCH] package/gnupg: fix TAR path in gpg-zip script Thomas Petazzoni
2019-12-30 13:23 ` Yann E. MORIN
2019-12-30 20:40 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191230214016.5b865216@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox