Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/apitrace: fix build failure due to gcc bug 68485 and 85180
Date: Wed, 1 Jan 2020 10:14:53 +0100	[thread overview]
Message-ID: <20200101091453.GF3519@scaer> (raw)
In-Reply-To: <20191231195922.127164-1-giulio.benetti@benettiengineering.com>

Giulio, All,

On 2019-12-31 20:59 +0100, Giulio Benetti spake thusly:
> The apitrace package exhibits gcc bug 68485 when built for the
> Microblaze architecture with optimization enabled, which causes a build
> failure. This is mainly due to 3rd party brotli embedded in apitrace
> that already has been fixed in Buildroot as single package. After
> working around this bug overriding -O0 to CFLAGS(Brotli is a C program),
> gcc bug 81580 showed off while compiling C++ files.
> 
> So, as done for other packages in Buildroot, work around this gcc bug by
> setting optimization to -O0(in CFLAGS) if
> BR2_TOOLCHAIN_HAS_GCC_BUG_68485=y. And do the same(but in CXXFLAGS) if
> BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y as already done for other packages.
> 
> Fixes:
> http://autobuild.buildroot.net/results/a46/a46626cc50f07f41d831614306f556d346d31429/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Applied to master, with a slight reorganising of the code Thanks!

Regards,
Yann E. MORIN.

> ---
> V1->V2:
> * Added comments into apitrace.mk
> * Improved commit log
> ---
>  package/apitrace/apitrace.mk | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/package/apitrace/apitrace.mk b/package/apitrace/apitrace.mk
> index e6f8a2b1c5..2b74ba26df 100644
> --- a/package/apitrace/apitrace.mk
> +++ b/package/apitrace/apitrace.mk
> @@ -21,4 +21,22 @@ endif
>  # Gui was never tested, so we prefer to explicitly disable it
>  APITRACE_CONF_OPTS += -DENABLE_GUI=false
>  
> +APITRACE_CFLAGS = $(TARGET_CFLAGS)
> +
> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
> +# This works around embedded Brotli build failure
> +APITRACE_CFLAGS += -O0
> +endif
> +
> +APITRACE_CONF_OPTS += -DCMAKE_C_FLAGS="$(APITRACE_CFLAGS)"
> +
> +APITRACE_CXXFLAGS = $(TARGET_CXXFLAGS)
> +
> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
> +# This works around Apitrace itself build failure
> +APITRACE_CXXFLAGS += -O0
> +endif
> +
> +APITRACE_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(APITRACE_CXXFLAGS)"
> +
>  $(eval $(cmake-package))
> -- 
> 2.20.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2020-01-01  9:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-27 18:00 [Buildroot] [PATCH] package/apitrace: fix build failure due to gcc bug 68485 and 85180 Giulio Benetti
2019-12-31 14:33 ` Thomas Petazzoni
2019-12-31 15:04   ` Giulio Benetti
2019-12-31 17:08     ` Thomas Petazzoni
2019-12-31 19:59       ` [Buildroot] [PATCH v2] " Giulio Benetti
2020-01-01  9:14         ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200101091453.GF3519@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox