From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Wed, 1 Jan 2020 16:32:58 +0100 Subject: [Buildroot] [PATCH] package/libnss: fix build failure due to HW PPC Crypto bug In-Reply-To: References: <20191227165427.107111-1-giulio.benetti@benettiengineering.com> <20191231180736.09a5add2@windsurf> <496f5949-570f-2678-6bcd-67660692479b@benettiengineering.com> <08c5d316-d21b-f361-1506-af6a3bdd46e0@xes-inc.com> Message-ID: <20200101163258.13c7de62@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Wed, 1 Jan 2020 00:44:09 +0100 Giulio Benetti wrote: > >> So if we stick with nss-3.48, the package should likely depend on > >> BR2_TOOLCHAIN_GCC_AT_LEAST_8. > > This ^^^ is too restrictive, but... > > > Or don't utilize PPC hardware accelerated instructions by undefining > > USE_PPC_CRYPTO... which is probably the saner option :-). This would > > give the semblance that the compile worked as expected since the hashing > > function will now be available, but Thomas' concern re CPU_ARCH and the > > future inclusion of ppc specific source is still valid. > > ...this is a good idea. So with gcc version < 8.x let's disable > USE_PPC_CRYPTO and with gcc version >= 8.x let's enable it only if > LITTLE_ENDIAN. So at this point I would change my upstream patch to do > that in NSS, since there's already a gcc version check but only against > version 5.x(>=) that instead needs to be >= 8.x. As I said in my previous e-mail, I also don't see how it can work with the current OS_TEST value that we pass in libnss.mk, which is never set to ppc64 or ppc64le as the libnss build system expects. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com