Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5] utils/scancpan: warn when a module is a perl core module
Date: Sat, 4 Jan 2020 09:02:34 +0100	[thread overview]
Message-ID: <20200104080234.GA2312@scaer> (raw)
In-Reply-To: <CAAXf6LVoWMk6ESza5jY40a9H_067iw3MJ5ksjwQ4Zbm4KbLJbQ@mail.gmail.com>

Thomas, Fran?ois, All,

On 2020-01-03 16:56 +0100, Thomas De Schampheleire spake thusly:
> El dom., 22 dic. 2019 a las 17:33, Yann E. MORIN
> (<yann.morin.1998@free.fr>) escribi?:
> > On 2019-12-22 17:21 +0100, Francois Perrad spake thusly:
> > > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> >
> > This change does need to be explained in the commit log:
> >
> >   - Why is it bad that we have a pacakge that is a core module?
> >   - Does it cause any issue? If so, which one?
> >
> > Also, when you do removes package, the least is to add in Cc the people
> > that initially added the package, so they have a chance to chime in and
> > explain why they wanted to add it in the first place, and so they can
> > confirm that the core module does indeed work for them.
> >
> > I'll mark the whole series as Changes Requested in Patchowrk. Please
> > respin with explanations, and Cc original packagers.
> 
> When submitting the package perl-math-bigint I was not aware that it
> was a core package.
> After Fran?ois mentioned it, we checked internally if indeed things
> work fine without the Buildroot package, and it is the case.
> So, there is no need for package/perl-math-bigint.
> 
> There is no actual harm by also having a Buildroot package, except for:
> - unneeded stuff in Buildroot
> - potential to eclipse a newer version of the package when
> package/perl evolves but package/perl-math-bigint does not.
> 
> So from my point of view I would indeed remove the package again.
> I was actually going to send a revert but then I saw this series.

Thanks for the feedback. I had seen the previous forth-n-back about
math-bigint too, so was pretty aware of the situation. Nonetheless, it
should have been explained in the commit log.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2020-01-04  8:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-22 16:21 [Buildroot] [PATCH 1/5] utils/scancpan: warn when a module is a perl core module Francois Perrad
2019-12-22 16:21 ` [Buildroot] [PATCH 2/5] package/perl-digest-md5: remove it Francois Perrad
2019-12-22 16:21 ` [Buildroot] [PATCH 3/5] package/perl-math-bigint: " Francois Perrad
2020-01-03 15:51   ` Thomas De Schampheleire
2019-12-22 16:21 ` [Buildroot] [PATCH 4/5] package/perl-mime-base: " Francois Perrad
2019-12-22 16:21 ` [Buildroot] [PATCH 5/5] package/perl-net-ping: " Francois Perrad
2019-12-22 16:33 ` [Buildroot] [PATCH 1/5] utils/scancpan: warn when a module is a perl core module Yann E. MORIN
2020-01-03 15:56   ` Thomas De Schampheleire
2020-01-04  8:02     ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200104080234.GA2312@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox