Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] board/raspberrypi/post-image.sh: support older defconfigs
Date: Mon, 6 Jan 2020 10:54:09 +0100	[thread overview]
Message-ID: <20200106105409.24949715@gmx.net> (raw)
In-Reply-To: <20200103003752.140-1-chrismcc@gmail.com>

Hello Christopher,

On Fri,  3 Jan 2020 00:37:51 +0000, Christopher McCrory <chrismcc@gmail.com> wrote:

> Commit ada40afb324 fixed pi3-minuart-bt being changed to miniuart-bt.  Older
> defconfig files based on raspberrypi*_defconfigs might have to old call,
> BR2_ROOTFS_POST_SCRIPT_ARGS="--add-pi3-miniuart-bt-overlay"
> Allow either argument to add the correct miniuart-bt overlay.
>
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
> ---
>  board/raspberrypi/post-image.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/raspberrypi/post-image.sh b/board/raspberrypi/post-image.sh
> index 9dbd98ef9b..e9246fa113 100755
> --- a/board/raspberrypi/post-image.sh
> +++ b/board/raspberrypi/post-image.sh
> @@ -10,7 +10,7 @@ GENIMAGE_TMP="${BUILD_DIR}/genimage.tmp"
>  for arg in "$@"
>  do
>  	case "${arg}" in
> -		--add-miniuart-bt-overlay)
> +		--add-miniuart-bt-overlay|--add-pi3-miniuart-bt-overlay)

In favour for this one ;-), suggested for the pi3-miniuart/miniuart change
commit [1], but rejected by the maintainers [2]...

Regards
Peter

[1] http://lists.busybox.net/pipermail/buildroot/2019-December/268042.html
[2] http://lists.busybox.net/pipermail/buildroot/2019-December/268046.html

>  		if ! grep -qE '^dtoverlay=' "${BINARIES_DIR}/rpi-firmware/config.txt"; then
>  			echo "Adding 'dtoverlay=miniuart-bt' to config.txt (fixes ttyAMA0 serial console)."
>  			cat << __EOF__ >> "${BINARIES_DIR}/rpi-firmware/config.txt"

  parent reply	other threads:[~2020-01-06  9:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-03  0:37 [Buildroot] [PATCH 1/2] board/raspberrypi/post-image.sh: support older defconfigs Christopher McCrory
2020-01-03  0:37 ` [Buildroot] [PATCH 2/2] configs/raspberrypi0w_defconfig: fix post script args Christopher McCrory
2020-01-06  9:55   ` Peter Seiderer
2020-01-06 17:58   ` Yann E. MORIN
2020-01-06  9:54 ` Peter Seiderer [this message]
2020-01-06 18:00 ` [Buildroot] [PATCH 1/2] board/raspberrypi/post-image.sh: support older defconfigs Yann E. MORIN
2020-01-06 22:12   ` Christopher McCrory

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200106105409.24949715@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox