From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/6] package/alure: add libvorbis decoder option
Date: Sun, 12 Jan 2020 21:32:09 +0100 [thread overview]
Message-ID: <20200112213209.792636e6@windsurf> (raw)
In-Reply-To: <20200105113204.30356-4-romain.naour@gmail.com>
On Sun, 5 Jan 2020 12:32:02 +0100
Romain Naour <romain.naour@gmail.com> wrote:
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> ---
> package/alure/Config.in | 7 +++++++
> package/alure/alure.mk | 8 +++++++-
> 2 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/package/alure/Config.in b/package/alure/Config.in
> index 7947e30a1f..20b9e4e4e9 100644
> --- a/package/alure/Config.in
> +++ b/package/alure/Config.in
> @@ -30,6 +30,13 @@ config BR2_PACKAGE_ALURE_OPUS_DECODER
> help
> Enables the built-in libopusfile decoder.
>
> +config BR2_PACKAGE_ALURE_VORBIS_DECODER
> + bool "vorbis decoder"
> + select BR2_PACKAGE_LIBVORBIS
> + select BR2_PACKAGE_OPUS
This doesn't match what you're doing in the .mk file: the .mk file adds
a dependency on libogg and libvorbis, and this is what is correct. So
I've replaced the select BR2_PACKAGE_OPUS by a select
BR2_PACKAGE_LIBOGG.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-01-12 20:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 11:31 [Buildroot] [PATCH 1/6] package/alure: new package Romain Naour
2020-01-05 11:32 ` [Buildroot] [PATCH 2/6] package/alure: add flac decoder option Romain Naour
2020-01-05 11:32 ` [Buildroot] [PATCH 3/6] package/alure: add opus " Romain Naour
2020-01-05 11:32 ` [Buildroot] [PATCH 4/6] package/alure: add libvorbis " Romain Naour
2020-01-12 20:32 ` Thomas Petazzoni [this message]
2020-01-05 11:32 ` [Buildroot] [PATCH 5/6] package/alure: add libsndfile " Romain Naour
2020-01-05 11:32 ` [Buildroot] [PATCH 6/6] package/alure: add minimp3 " Romain Naour
2020-01-12 20:31 ` [Buildroot] [PATCH 1/6] package/alure: new package Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200112213209.792636e6@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox