From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] infra: add the transient download mechanism
Date: Thu, 16 Jan 2020 11:05:38 +0100 [thread overview]
Message-ID: <20200116110538.335a41b9@windsurf> (raw)
In-Reply-To: <e7e0088e1b76adf1492f06e81b386a0018b9336b.camel@orolia.com>
On Thu, 16 Jan 2020 10:01:09 +0000
Nicolas Carrier <nicolas.carrier@orolia.com> wrote:
> Just to be sure I understand, when you say "when TRANSIENT_DOWNLOAD is
> NO.", it'd be the same as if TRANSIENT_DOWNLOAD download is not defined
> at all, right?
Yes.
There is maybe a little bit of an issue in Yann's current
implementation as he does:
$(if $($(2)_DOWNLOAD_TRANSIENT),-F) \
so in fact, -F would be passed as soon as <pkg>_DOWNLOAD_TRANSIENT is
non-empty, so <pkg>_DOWNLOAD_TRANSIENT = NO would in fact pass -F.
But this bug already exists for <pkg>_GIT_SUBMODULES:
$(if $($(2)_GIT_SUBMODULES),-r) \
And it is trivial to fix.
> If it's the case, then that seems to me like a good idea, because it
> renders explicit the risk taken by the user when using a branch (which
> can be done unknowingly ATM).
Absolutely.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-01-16 10:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 20:37 [Buildroot] [PATCH] infra: add the transient download mechanism Yann E. MORIN
2020-01-15 22:04 ` Michael Nazzareno Trimarchi
2020-01-16 22:36 ` Arnout Vandecappelle
2020-01-16 9:11 ` Nicolas Carrier
2020-01-16 9:31 ` Thomas Petazzoni
2020-01-16 9:56 ` Michael Nazzareno Trimarchi
2020-01-16 10:03 ` Thomas Petazzoni
2020-01-16 10:15 ` Michael Nazzareno Trimarchi
2020-01-16 15:35 ` Yann E. MORIN
2020-01-16 16:52 ` Michael Nazzareno Trimarchi
2020-01-16 10:01 ` Nicolas Carrier
2020-01-16 10:05 ` Thomas Petazzoni [this message]
2020-01-16 15:45 ` Yann E. MORIN
2020-01-16 15:29 ` Yann E. MORIN
2020-01-16 22:49 ` Arnout Vandecappelle
2020-04-08 6:39 ` Thomas Petazzoni
2020-04-08 19:27 ` Yann E. MORIN
2020-04-08 20:03 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2020-04-27 20:04 Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116110538.335a41b9@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox