Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] host-python-2.7 failure to build _hashlib
Date: Tue, 28 Jan 2020 14:44:12 +0100	[thread overview]
Message-ID: <20200128144412.16fe35b1@windsurf> (raw)
In-Reply-To: <CA+h21hrqSponHMwMUBXhRaCmnVjwzrhKJSH+XSZcO8Zp69JFmA@mail.gmail.com>

On Tue, 28 Jan 2020 12:28:01 +0200
Vladimir Oltean <olteanv@gmail.com> wrote:

> > diff --git a/package/python/python.mk b/package/python/python.mk
> > index 41a981e3d3..cd79be78f6 100644
> > --- a/package/python/python.mk
> > +++ b/package/python/python.mk
> > @@ -33,7 +33,8 @@ HOST_PYTHON_CONF_OPTS += \
> >         --disable-test-modules \
> >         --disable-bz2 \
> >         --disable-ossaudiodev \
> > -       --disable-pyo-build
> > +       --disable-pyo-build \
> > +       --disable-hashlib  
> 
> Yes, this works, but I'm not exactly sure what conclusion I should draw from it.

I explained above the patch in my previous e-mail what (I believe) was
happening.

> hashlib seems to require BR2_PACKAGE_HOST_PYTHON_SSL, but without a
> proper dependency tracking system for host packages, I don't know how
> it can be disabled in that case.

Three solutions:

 - We hook into the BR2_PACKAGE_HOST_PYTHON_SSL option, and add
   --disable-hashlib in the "else" case of this condition. This makes
   the BR2_PACKAGE_HOST_PYTHON_SSL option have the semantic "build all
   Python modules that depend on OpenSSL".

 - We create a separate BR2_PACKAGE_HOST_PYTHON_HASHLIB option, so that
   the semantic of BR2_PACKAGE_HOST_PYTHON_SSL remains "build the
   Python ssl module"

 - We simply unconditionally add --disable-hashlib like I proposed, and
   wait until someone needs hashlib in host-python.

I suggest we take the third solution for now.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2020-01-28 13:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27 22:35 [Buildroot] host-python-2.7 failure to build _hashlib Vladimir Oltean
2020-01-27 22:40 ` Thomas Petazzoni
2020-01-27 23:39   ` Vladimir Oltean
2020-01-28  9:14     ` Thomas Petazzoni
2020-01-28 10:28       ` Vladimir Oltean
2020-01-28 13:44         ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200128144412.16fe35b1@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox