From: Vincent Fazio <vfazio@xes-inc.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] toolchain/toolchain-buildroot: PPC64(LE) support in musl requires ALTIVEC
Date: Fri, 31 Jan 2020 09:39:52 -0600 [thread overview]
Message-ID: <20200131153952.680-1-vfazio@xes-inc.com> (raw)
musl currently assumes all PPC64(LE) CPUs support ALTIVEC instructions.
However, there are exceptions (such as the e5500) for which musl builds
ultimately generate illegal instructions for the targets.
Disable musl if the PPC64(LE) CPU does not support ALTIVEC instructions.
This patch addresses the issues seen here:
https://gitlab.com/kubu93/toolchains-builder/-/jobs/418092743
https://gitlab.com/kubu93/toolchains-builder/-/jobs/418092744
Signed-off-by: Vincent Fazio <vfazio@xes-inc.com>
---
toolchain/toolchain-buildroot/Config.in | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/toolchain/toolchain-buildroot/Config.in b/toolchain/toolchain-buildroot/Config.in
index a980f766ac..09a46822c9 100644
--- a/toolchain/toolchain-buildroot/Config.in
+++ b/toolchain/toolchain-buildroot/Config.in
@@ -83,8 +83,10 @@ config BR2_TOOLCHAIN_BUILDROOT_MUSL
bool "musl"
depends on BR2_aarch64 || BR2_arm || BR2_armeb || BR2_i386 || \
BR2_microblaze || BR2_mips || BR2_mipsel || BR2_mips64 || \
- BR2_mips64el || BR2_or1k || BR2_powerpc || BR2_powerpc64 || \
- BR2_powerpc64le || BR2_RISCV_64 || BR2_sh || BR2_x86_64
+ BR2_mips64el || BR2_or1k || BR2_powerpc || BR2_RISCV_64 || \
+ BR2_sh || BR2_x86_64 || \
+ ((BR2_powerpc64 || BR2_powerpc64le) && BR2_POWERPC_CPU_HAS_ALTIVEC)
+ # musl assumes all PPC64 targets support ALTIVEC instructions
depends on !BR2_powerpc_SPE # not supported, build breaks
# sh2 nommu is supported by musl, but we don't have support
# for it in Buildroot.
--
2.25.0
next reply other threads:[~2020-01-31 15:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 15:39 Vincent Fazio [this message]
2020-02-04 16:11 ` [Buildroot] [PATCH v2 1/1] toolchain/toolchain-buildroot: PPC64(LE) support in musl requires ALTIVEC Romain Naour
2020-02-04 16:54 ` Vincent Fazio
2020-02-04 19:25 ` [Buildroot] [PATCH v3 " Vincent Fazio
2020-02-04 20:55 ` Romain Naour
2020-02-04 21:35 ` [Buildroot] [PATCH v4 " Vincent Fazio
2020-02-04 21:38 ` Romain Naour
2020-04-20 21:40 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131153952.680-1-vfazio@xes-inc.com \
--to=vfazio@xes-inc.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox