From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support
Date: Sat, 1 Feb 2020 10:24:25 +0100 [thread overview]
Message-ID: <20200201102425.1556253b@windsurf> (raw)
In-Reply-To: <20200201084758.285234-1-bernd.kuhls@t-online.de>
On Sat, 1 Feb 2020 09:47:57 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> nspr 4.25 added support for Xtensa architecture:
> https://groups.google.com/forum/#!topic/mozilla.dev.tech.nspr/lK7toqtJ96E
>
> Removed BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT because it was only needed for
> xtensa.
>
> Added sha1 hash provided by upstream.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
I don't feel very strongly about it, but I'm wondering if it doesn't
make sense to keep BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT. There is some
architecture-specific code in libnpsr, so every time we add a new CPU
architecture, we would have to poentially re-add this hidden option.
More specifically, I have been working on using Buildroot for a new CPU
architecture (not yet upstream, but will be submitted in the future),
and it was quite nice to have this BR2_PACKAGE_LIBNPSR_ARCH_SUPPORT to
disable libnpsr on this CPU architecture for the moment.
But again, I don't feel very strongly, it can very well be re-added
later if need be.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-02-01 9:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 8:47 [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support Bernd Kuhls
2020-02-01 8:47 ` [Buildroot] [PATCH 2/2] package/libnss: bump version to 3.49.2 Bernd Kuhls
2020-02-01 12:30 ` Giulio Benetti
2020-02-01 9:24 ` Thomas Petazzoni [this message]
2020-02-04 8:25 ` [Buildroot] [PATCH 1/2] package/libnspr: bump to version 4.25, add xtensa support Arnout Vandecappelle
2020-02-04 8:33 ` Thomas Petazzoni
2020-02-04 9:52 ` Giulio Benetti
2020-02-01 12:35 ` Giulio Benetti
2020-02-01 13:21 ` Bernd Kuhls
2020-02-01 13:24 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200201102425.1556253b@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox