Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/rng-tools: make jitterentropy conditional
Date: Wed, 5 Feb 2020 20:32:57 +0100	[thread overview]
Message-ID: <20200205203257.48877881@windsurf> (raw)
In-Reply-To: <20200205182608.22695-1-matthew.weber@rockwellcollins.com>

On Wed,  5 Feb 2020 12:26:08 -0600
Matt Weber <matthew.weber@rockwellcollins.com> wrote:

> The update of rng-tools from 5 to 6.7 introduced a change where
> the jitterentropy library was enabled by default instead of
> returning a special 66 return code to hangle the case of no
> hwrng. This patch reverts that change and allows a user to
> select when to enable the jitterentropy source. The bug
> documents an issue of when a hwrng is enabled with jitterentropy
> there is a longer boot time.

I don't understand this story of the 66 return code. Could you explain
a bit more ?

> index 11386d1e5d..c0bcffe59e 100644
> --- a/package/rng-tools/rngd.service
> +++ b/package/rng-tools/rngd.service
> @@ -3,6 +3,7 @@ Description=Hardware RNG Entropy Gatherer Daemon
>  
>  [Service]
>  ExecStart=/usr/sbin/rngd -f $DAEMON_ARGS
> +SuccessExitStatus=66

Will this work even if jitterentropy support is enabled ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-02-05 19:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-05 18:26 [Buildroot] [PATCH] package/rng-tools: make jitterentropy conditional Matt Weber
2020-02-05 19:32 ` Thomas Petazzoni [this message]
2020-02-05 20:46   ` Matthew Weber
2020-02-06  1:12     ` Matthew Weber
2020-02-08 19:12       ` Peter Korsgaard
2020-02-11 15:03         ` Matthew Weber
2020-02-11 15:21           ` Yegor Yefremov
2020-02-13 17:07             ` Matthew Weber
2020-05-18  7:48               ` Thomas Petazzoni
2020-05-19 22:08                 ` Matthew Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200205203257.48877881@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox