Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/uclibc: restore __isctype_l definition
Date: Sun, 9 Feb 2020 22:34:07 +0100	[thread overview]
Message-ID: <20200209213407.GW23769@scaer> (raw)
In-Reply-To: <20200209200937.25440-1-jcmvbkbc@gmail.com>

Max, All,

On 2020-02-09 12:09 -0800, Max Filippov spake thusly:
> Recent is*_l fix broke uclibc build because removed __isctype_l
> definition was used in libc/misc/ctype/ctype.c. Restore it.
> 
> Fixes: 8723c5e7a6db ("package/uclibc: fix ctype.h is*_l definitions")
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>

Thanks for the quick fix! :-)

I've applied to master, with the folowing changes:

  - add new patch, don't fix existing one
  - add URL to upstream ML post

Regards,
Yann E. MORIN.

> ---
>  .../0001-include-ctype.h-drop-is-_l-macro-definitions.patch   | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/uclibc/0001-include-ctype.h-drop-is-_l-macro-definitions.patch b/package/uclibc/0001-include-ctype.h-drop-is-_l-macro-definitions.patch
> index 5557a9c1e730..41c9d3d2bd81 100644
> --- a/package/uclibc/0001-include-ctype.h-drop-is-_l-macro-definitions.patch
> +++ b/package/uclibc/0001-include-ctype.h-drop-is-_l-macro-definitions.patch
> @@ -20,7 +20,7 @@ diff --git a/include/ctype.h b/include/ctype.h
>  index ecd5e730886a..e934cf3321a6 100644
>  --- a/include/ctype.h
>  +++ b/include/ctype.h
> -@@ -350,46 +350,13 @@ libc_hidden_proto(tolower_l)
> +@@ -350,46 +350,14 @@ libc_hidden_proto(tolower_l)
>   /* Return the uppercase version of C.  */
>   extern int toupper_l (int __c, __locale_t __l) __THROW;
>   
> @@ -30,7 +30,7 @@ index ecd5e730886a..e934cf3321a6 100644
>  -# endif	/* Optimizing gcc */
>  -
>  -
> --# define __isctype_l(c, type, locale) ((locale)->__ctype_b[(int) (c)] & (__ctype_mask_t) type)
> + # define __isctype_l(c, type, locale) ((locale)->__ctype_b[(int) (c)] & (__ctype_mask_t) type)
>   # ifndef __NO_CTYPE
>  -#  define __isalnum_l(c,l)	__isctype_l((c), _ISalnum, (l))
>  -#  define __isalpha_l(c,l)	__isctype_l((c), _ISalpha, (l))
> -- 
> 2.20.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-02-09 21:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-09 20:09 [Buildroot] [PATCH] package/uclibc: restore __isctype_l definition Max Filippov
2020-02-09 21:34 ` Yann E. MORIN [this message]
2020-03-10 22:20 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200209213407.GW23769@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox