Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Matyukevich <geomatsi@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/wpa_supplicant: disable TEAP for internal TLS implementation
Date: Sun, 16 Feb 2020 17:38:03 +0300	[thread overview]
Message-ID: <20200216143803.GA2902@curiosity> (raw)
In-Reply-To: <20200114080234.lcyzcovnetczvw6i@bars>

> > > EAP-TEAP support in hostapd/wpa_supplicant fails to build with internal
> > > TLS implementation. This patch disables TEAP support in wpa_supplicant
> > > when internal TLS implementation is selected. Similar fix for hostapd
> > > package has already been merged to Buildroot: see commit 47d14e3b1c20
> > > ("package/hostapd: disable TEAP for internal TLS implementation").
> > > 
> > > TEAP is still an experimental feature that is not recommmended for
> > > production use. Currently it should not be used for anything else
> > > than experimentation and interoperability testing. Those who needs
> > > experimenting with TEAP are encouraged to enable openssl in their
> > > buildroot configuration.
> > 
> >  So then why don't we just unconditionally disable this feature? Preferably with
> > a comment in the .mk file that it's disabled due to its experimental nature, so
> > that someone who needs it a couple of years down the line can note that it's not
> > longer experimental.
> 
> Well, this is another possible option. But I don't see why we should
> disable it completely. TEAP does not build with internal hostapd TLSv1
> implementation, which in its turn is also marked as experimental. On
> the other hand, TEAP successfully builds if OpenSSL is selected as TLS
> implementation. So why don't we just disable known broken combination,
> leaving the choice between working combinations to the end user.

Hi Thomas, Arnout,

It has been a while since my last reply. Do you still have any other
concerns regarding suggested approach ?

Let me reiterate the idea. TEAP is a farily new and experimental hostapd
feature which does not compile with internal hostapd TLS implementation.
On the other hand, it can be successfully built with OpenSSL as TLS
provider for hostapd.

So suggested approach explicitly disables broken configuration, but still
lets the users to play with it if they need to.

Regards,
Sergey

  reply	other threads:[~2020-02-16 14:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08 19:04 [Buildroot] [PATCH 1/1] package/wpa_supplicant: disable TEAP for internal TLS implementation Sergey Matyukevich
2020-01-13 23:05 ` Arnout Vandecappelle
2020-01-14  8:02   ` Sergey Matyukevich
2020-02-16 14:38     ` Sergey Matyukevich [this message]
2020-03-15 20:07 ` Sergey Matyukevich
2020-08-13 21:08 ` Thomas Petazzoni
2020-08-28 16:25   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200216143803.GA2902@curiosity \
    --to=geomatsi@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox