From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC PATCH] package/sdbusplus: fix the build
Date: Wed, 19 Feb 2020 21:03:13 +0100 [thread overview]
Message-ID: <20200219210313.6f29cc6c@windsurf> (raw)
In-Reply-To: <20200210191131.2520-1-michael@walle.cc>
On Mon, 10 Feb 2020 20:11:30 +0100
Michael Walle <michael@walle.cc> wrote:
> Commit d255b67972b4b7f27572581fe0c8c8aa03d850c8 fixed the handling of
> the a package local m4/ directory which might be missing. But this only
> works if it is the very first argument. But for this package this is not
> possible because we already occupy this with the extra include directory
> for autoconf-archive. Bring back the hook to create the m4/ directory to
> fix this.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
The commit log was missing a reference to the autobuilder failure that
this commit fixes, so I've added it and applied to master.
I looked at the discussion with Yann, and yes some more elaborate
solution could perhaps be introduced to avoid the hook. But for now the
work done on autoconf allows to avoid the hook in most situations,
except when autoconf-archive is needed, which is only a small minority
of our packages. For these packages, it is good enough for now to keep
an explicit hook to create the m4 directory.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2020-02-19 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 19:11 [Buildroot] [RFC PATCH] package/sdbusplus: fix the build Michael Walle
2020-02-10 20:57 ` Yann E. MORIN
2020-02-10 23:02 ` Michael Walle
2020-02-19 20:03 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219210313.6f29cc6c@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox