Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: unixmania at gmail.com <unixmania@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/radvd: disable by default in systemd preset-all
Date: Sat, 22 Feb 2020 11:47:06 -0300	[thread overview]
Message-ID: <20200222144706.7896-1-unixmania@gmail.com> (raw)

From: Carlos Santos <unixmania@gmail.com>

We don't provide a configuration file, so disable radvd by default.

Update the help message with instructions on how to enable radvd at
build time with systemd.

Signed-off-by: Carlos Santos <unixmania@gmail.com>
---
 package/radvd/50-radvd.preset | 1 +
 package/radvd/Config.in       | 8 ++++++++
 package/radvd/radvd.mk        | 6 ++++++
 3 files changed, 15 insertions(+)
 create mode 100644 package/radvd/50-radvd.preset

diff --git a/package/radvd/50-radvd.preset b/package/radvd/50-radvd.preset
new file mode 100644
index 0000000000..90d0ee4bbc
--- /dev/null
+++ b/package/radvd/50-radvd.preset
@@ -0,0 +1 @@
+disable radvd.service
diff --git a/package/radvd/Config.in b/package/radvd/Config.in
index 48aeedc08f..fa5a20c4c1 100644
--- a/package/radvd/Config.in
+++ b/package/radvd/Config.in
@@ -5,4 +5,12 @@ config BR2_PACKAGE_RADVD
 	help
 	  IPv6 Router Advertisement Daemon.
 
+	  On busybox and sysvinit systems, radvd will be started only if
+	  a /etc/radvd.conf exists.
+
+	  To enable it at build time with systemd, add /etc/radvd.conf
+	  and a /etc/systemd/system-preset/40-radvd.preset file with
+
+	    enable radvd.service
+
 	  http://www.litech.org/radvd/
diff --git a/package/radvd/radvd.mk b/package/radvd/radvd.mk
index 5679e613d4..3358264f18 100644
--- a/package/radvd/radvd.mk
+++ b/package/radvd/radvd.mk
@@ -17,6 +17,12 @@ RADVD_AUTORECONF = YES
 RADVD_LICENSE = BSD-4-Clause-like
 RADVD_LICENSE_FILES = COPYRIGHT
 
+# We don't provide /etc/radvd.conf, so disable the service by default.
+define RADVD_INSTALL_INIT_SYSTEMD
+	$(INSTALL) -D -m 0644 package/radvd/50-radvd.preset \
+		$(TARGET_DIR)/usr/lib/systemd/system-preset/50-radvd.preset
+endef
+
 define RADVD_INSTALL_INIT_SYSV
 	$(INSTALL) -D -m 0755 package/radvd/S50radvd $(TARGET_DIR)/etc/init.d/S50radvd
 endef
-- 
2.18.2

             reply	other threads:[~2020-02-22 14:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-22 14:47 unixmania at gmail.com [this message]
2020-02-22 18:12 ` [Buildroot] [PATCH] package/radvd: disable by default in systemd preset-all Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200222144706.7896-1-unixmania@gmail.com \
    --to=unixmania@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox