From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] docs/manual: clarify the <PKG>_PATCH_DEPENDENCIES guarantee
Date: Sun, 23 Feb 2020 09:32:27 +0100 [thread overview]
Message-ID: <20200223083227.GH8743@scaer> (raw)
In-Reply-To: <0129871638f614e8794dcf2576131d41bf64986d.1582263282.git.baruch@tkos.co.il>
Baruch, All,
On 2020-02-21 07:34 +0200, Baruch Siach spake thusly:
> Unlike <PKG>_DEPENDENCIES, <PKG>_PATCH_DEPENDENCIES only guarantees
> extract and patch of listed dependencies, not build. Make this subtlety
> more explicit in the documentation.
>
> Cc: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> docs/manual/adding-packages-generic.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt
> index 59cdb7ffd72d..82d97854dde4 100644
> --- a/docs/manual/adding-packages-generic.txt
> +++ b/docs/manual/adding-packages-generic.txt
> @@ -374,9 +374,9 @@ not and can not work as people would expect it should:
> * +LIBFOO_PATCH_DEPENDENCIES+ lists the dependencies (in terms of
> package name) that are required for the current package to be
> patched. These dependencies are guaranteed to be extracted and
> - patched before the current package is patched. In a similar way,
> - +HOST_LIBFOO_PATCH_DEPENDENCIES+ lists the dependencies for the
> - current host package.
> + patched (but not necessarily be built) before the current package
Here I dropped the 'be' in front of 'built'.
Applied to master, thanks! :-)
Regards,
Yann E. MORIN.
> + is patched. In a similar way, +HOST_LIBFOO_PATCH_DEPENDENCIES+ lists
> + the dependencies for the current host package.
> This is seldom used; usually, +LIBFOO_DEPENDENCIES+ is what you
> really want to use.
>
> --
> 2.25.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2020-02-23 8:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 5:34 [Buildroot] [PATCH] docs/manual: clarify the <PKG>_PATCH_DEPENDENCIES guarantee Baruch Siach
2020-02-23 8:32 ` Yann E. MORIN [this message]
2020-03-14 14:41 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200223083227.GH8743@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox