Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: vadim4j at gmail.com <vadim4j@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/rtrlib: new package
Date: Mon, 24 Feb 2020 23:00:46 +0200	[thread overview]
Message-ID: <20200224210046.GB34982@archlinux> (raw)
In-Reply-To: <20200224205313.109d44bd@windsurf>

Hi Thomas,

On Mon, Feb 24, 2020 at 08:53:13PM +0100, Thomas Petazzoni wrote:
> Hello Vadim,
> 
> On Mon, 24 Feb 2020 19:26:51 +0200
> Vadim Kochan <vadim4j@gmail.com> wrote:
> 
> > diff --git a/package/rtrlib/Config.in b/package/rtrlib/Config.in
> > new file mode 100644
> > index 0000000000..440eeb5d63
> > --- /dev/null
> > +++ b/package/rtrlib/Config.in
> > @@ -0,0 +1,13 @@
> > +config BR2_PACKAGE_RTRLIB
> > +	bool "rtrlib"
> > +	depends on BR2_TOOLCHAIN_HAS_THREADS
> > +	depends on BR2_TOOLCHAIN_HAS_SSP
> 
> It's pretty uncommon for a package to require SSP support. Can you tell
> it instead to not pass -fstack-protector when building, and let
> Buildroot decide when to pass it ?
> 

I will try, but actually actually I was wrong that this package is
required by ffr, it is required but optionally for rpki support. So,
this patch might be dropped with not enabled rpki feature in frr.

Thanks,
Vadim Kochan

  reply	other threads:[~2020-02-24 21:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24 17:26 [Buildroot] [PATCH 0/3] add frr package Vadim Kochan
2020-02-24 17:26 ` [Buildroot] [PATCH 1/3] package/libyang: enable LYD_PRIV option Vadim Kochan
2020-02-24 19:52   ` Thomas Petazzoni
2020-02-24 20:36     ` vadim4j at gmail.com
2020-02-24 17:26 ` [Buildroot] [PATCH 2/3] package/rtrlib: new package Vadim Kochan
2020-02-24 19:53   ` Thomas Petazzoni
2020-02-24 21:00     ` vadim4j at gmail.com [this message]
2020-02-24 17:26 ` [Buildroot] [PATCH 3/3] package/frr: " Vadim Kochan
2020-02-24 20:06   ` Thomas Petazzoni
2020-02-24 21:14     ` vadim4j at gmail.com
2020-02-24 21:32       ` Thomas Petazzoni
2020-02-24 21:36         ` vadim4j at gmail.com
2020-02-24 22:07           ` Thomas Petazzoni
2020-02-25  1:28             ` vadim4j at gmail.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200224210046.GB34982@archlinux \
    --to=vadim4j@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox