From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/gnuplot: bump to version 5.2.8
Date: Wed, 26 Feb 2020 22:45:19 +0100 [thread overview]
Message-ID: <20200226224519.058d5cec@windsurf> (raw)
In-Reply-To: <20200217090658.5469-1-mf@go-sys.de>
Hello Michael,
On Mon, 17 Feb 2020 10:06:58 +0100
Michael Fischer <mf@go-sys.de> wrote:
> 0001-configure-add-without-demo-option: adapt patch to 5.2.8 version
> 0002-use-gdlib-config-properly: already applied upstream
>
> Signed-off-by: Michael Fischer <mf@go-sys.de>
Thanks for your contribution! If you're using gnuplot in Buildroot,
would you be willing to be listed as a developer for this package in
our DEVELOPERS file? This would help us maintain this package on the
long run.
I've applied your patch to our next branch, with a few changes. See below.
> diff --git a/package/gnuplot/0001-configure-add-without-demo-option.patch b/package/gnuplot/0001-configure-add-without-demo-option.patch
> index a9abfd06ba..890df55af9 100644
> --- a/package/gnuplot/0001-configure-add-without-demo-option.patch
> +++ b/package/gnuplot/0001-configure-add-without-demo-option.patch
> @@ -1,17 +1,17 @@
> -Add options to enable/disable docs and demos
> +-Add options to enable/disable docs and demos
> +-
> +-Originally written by Anthony Viallard
> +-<viallard@syscom-instruments.com>.
> +-
> +-[Vincent: adapt patch to 5.0.5 version]
> +-
> +-Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> +-Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Why did you add some - signs in front the description and Signed-off-by
lines? I dropped these, so that the patch description looks normal.
> diff --git a/package/gnuplot/gnuplot.hash b/package/gnuplot/gnuplot.hash
> index 1f3a08bb00..5c9ec636e4 100644
> --- a/package/gnuplot/gnuplot.hash
> +++ b/package/gnuplot/gnuplot.hash
> @@ -1,6 +1,3 @@
> -# From https://sourceforge.net/projects/gnuplot/files/gnuplot/5.0.6/
> -md5 8ec46520a86a61163a701b00404faf1a gnuplot-5.0.6.tar.gz
> -sha1 f7b8948166b22e5bd658d5cf7579716f4821dba0 gnuplot-5.0.6.tar.gz
We prefer to keep the upstream hashes, they are provided by
Sourceforge, so I updated this to 5.2.8 instead of dropping those
hashes.
Applied to next with those changes. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-02-26 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 9:06 [Buildroot] [PATCH] package/gnuplot: bump to version 5.2.8 Michael Fischer
2020-02-26 21:45 ` Thomas Petazzoni [this message]
[not found] ` <434318d67af84622b1a9200b63e18220@go-sys.de>
2020-02-27 9:15 ` Thomas Petazzoni
2020-02-27 12:10 ` Michael Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226224519.058d5cec@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox