Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next v1] package/gst1-plugins-base: add tools option
Date: Thu, 5 Mar 2020 23:34:10 +0100	[thread overview]
Message-ID: <20200305233410.76c4e8d0@windsurf> (raw)
In-Reply-To: <20200303164702.18418-1-ps.report@gmx.net>

On Tue,  3 Mar 2020 17:47:02 +0100
Peter Seiderer <ps.report@gmx.net> wrote:

> Add tools option to disable building/installing of
> gst-discoverer, gst-device-monitor and gst-play commandline
> tools (analog BR2_PACKAGE_GSTREAMER1_INSTALL_TOOLS).
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  package/gstreamer1/gst1-plugins-base/Config.in            | 7 +++++++
>  package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk | 6 ++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/package/gstreamer1/gst1-plugins-base/Config.in b/package/gstreamer1/gst1-plugins-base/Config.in
> index f60d540337..3a3694b72e 100644
> --- a/package/gstreamer1/gst1-plugins-base/Config.in
> +++ b/package/gstreamer1/gst1-plugins-base/Config.in
> @@ -10,6 +10,13 @@ menuconfig BR2_PACKAGE_GST1_PLUGINS_BASE
>  
>  if BR2_PACKAGE_GST1_PLUGINS_BASE
>  
> +config BR2_PACKAGE_GST1_PLUGINS_BASE_INSTALL_TOOLS
> +	bool "install gst-discoverer & gst-device-monitor & gst-play

Missing closing double quote. Also, I changed this to "install tools",
to keep the prompt shorter.

> +	default y

I know gstreamer1 does this, but this "default y" is really not in line
with the typical Buildroot policy of minimalism, so I dropped this.

Applied to next with those changes.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2020-03-05 22:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03 16:47 [Buildroot] [PATCH/next v1] package/gst1-plugins-base: add tools option Peter Seiderer
2020-03-05 22:34 ` Thomas Petazzoni [this message]
2020-03-06 14:34   ` Peter Seiderer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200305233410.76c4e8d0@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox