[Buildroot] [PATCH 1/1] package/qt5: add qt5remoteobjects library

[Peter Seiderer <ps.report@gmx.net>]

Hello Sven,

despite the line-wrapped/e-mail client problems some basic review...

Subject should be:

package/qt5remoteobjects: new package

On Sat, 7 Mar 2020 16:19:12 +0100, Sven Fischer <sven@leiderfischer.de> wrote:

> Qt 5.12 adds a library for IPC. This library is missing from the
> distributed qt5 package. Added it by using the library qt5serialport as
> a template and replaced serialport with remoteobjects, recalculated the
> sha256 sums.

All but the first sentence is better moved to patch cover-letter
or note below the first '---' (see below for example)...

>
> Signed-off-by: Sven Fischer <sven@leiderfischer.de>
> ---

Notes:
  - Added it by using the library qt5serialport as a template and replaced
    serialport with remoteobjects, recalculated the sha256 sums.


> package/qt5/Config.in | 1 +
> .../5.12.7/qt5remoteobjects.hash | 8 +++
> package/qt5/qt5remoteobjects/Config.in | 12 +++++
> .../qt5remoteobjects/qt5remoteobjects.hash | 2 +
> .../qt5/qt5remoteobjects/qt5remoteobjects.mk | 50 +++++++++++++++++++
> 5 files changed, 73 insertions(+)
> create mode 100644 package/qt5/qt5remoteobjects/5.12.7/qt5remoteobjects.hash
> create mode 100644 package/qt5/qt5remoteobjects/Config.in
> create mode 100644 package/qt5/qt5remoteobjects/qt5remoteobjects.hash
> create mode 100644 package/qt5/qt5remoteobjects/qt5remoteobjects.mk
>
> diff --git a/package/qt5/Config.in b/package/qt5/Config.in
> index 7051bf517a..2178c7d545 100644
> --- a/package/qt5/Config.in
> +++ b/package/qt5/Config.in
> @@ -54,6 +54,7 @@ source "package/qt5/qt5location/Config.in"
> source "package/qt5/qt5multimedia/Config.in"
> source "package/qt5/qt5quickcontrols/Config.in"
> source "package/qt5/qt5quickcontrols2/Config.in"
> +source "package/qt5/qt5remoteobjects/Config.in"
> source "package/qt5/qt5script/Config.in"
> source "package/qt5/qt5scxml/Config.in"
> source "package/qt5/qt5sensors/Config.in"
> diff --git a/package/qt5/qt5remoteobjects/5.12.7/qt5remoteobjects.hash
> b/package/qt5/qt5remoteobjects/5.12.7/qt5remoteobjects.hash
> new file mode 100644
> index 0000000000..4097dd8d54
> --- /dev/null
> +++ b/package/qt5/qt5remoteobjects/5.12.7/qt5remoteobjects.hash
> @@ -0,0 +1,8 @@
> +# Hash from:
> https://download.qt.io/official_releases/qt/5.12/5.12.7/submodules/qtremoteobjects-everywhere-src-5.12.7.tar.xz.sha256
> +sha256 6d6aaec4e9c140c027b0badaabc6322ea3c16cf649495a27fec1f261e891120f
> qtremoteobjects-everywhere-src-5.12.7.tar.xz
> +
> +# Hashes for license files:
> +sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643
> LICENSE.GPL2
> +sha256 8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903
> LICENSE.GPL3
> +sha256 0dbe024961f6ab5c52689cbd036c977975d0d0f6a67ff97762d96cb819dd5652
> LICENSE.GPL3-EXCEPT
> +sha256 da7eabb7bafdf7d3ae5e9f223aa5bdc1eece45ac569dc21b3b037520b4464768
> LICENSE.LGPL3
> diff --git a/package/qt5/qt5remoteobjects/Config.in
> b/package/qt5/qt5remoteobjects/Config.in
> new file mode 100644
> index 0000000000..bba5c5af1c
> --- /dev/null
> +++ b/package/qt5/qt5remoteobjects/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_QT5REMOTEOBJECTS
> + bool "qt5remoteobjects"
> + select BR2_PACKAGE_QT5BASE

$ head -1 build/qt5remoteobjects-5.12.7/qtremoteobjects.pro
requires(qtHaveModule(network))

Missing:

select BR2_PACKAGE_QT5BASE_NETWORK

> + help
> + Qt is a cross-platform application and UI framework for
> + developers using C++.
> +
> + Qt Remote Objects (QtRO) is an Inter-Process Communication (IPC) module
> + developed for Qt. This module extends Qt's existing functionalities to
> + enable information exchange between processes or computers, easily.
> +
> + http://doc.qt.io/qt-5/qtremoteobjects-index.html
> diff --git a/package/qt5/qt5remoteobjects/qt5remoteobjects.hash
> b/package/qt5/qt5remoteobjects/qt5remoteobjects.hash
> new file mode 100644
> index 0000000000..5316f03b10
> --- /dev/null
> +++ b/package/qt5/qt5remoteobjects/qt5remoteobjects.hash
> @@ -0,0 +1,2 @@
> +# This hash file is not used; instead, update the
> +# hash files in the per-version sub-directories.

Please re-base your patch against git next (the distinction
between LTS and Lates is gone), only Qt-5.12.x is supported,
no more need for an extra 5.12.7 subdirectory...

> diff --git a/package/qt5/qt5remoteobjects/qt5remoteobjects.mk
> b/package/qt5/qt5remoteobjects/qt5remoteobjects.mk
> new file mode 100644
> index 0000000000..7e9bd53aa0
> --- /dev/null
> +++ b/package/qt5/qt5remoteobjects/qt5remoteobjects.mk
> @@ -0,0 +1,50 @@
> +################################################################################
> +#
> +# qt5remoteobjects
> +#
> +################################################################################
> +
> +QT5REMOTEOBJECTS_VERSION = $(QT5_VERSION)
> +QT5REMOTEOBJECTS_SITE = $(QT5_SITE)
> +QT5REMOTEOBJECTS_SOURCE =
> qtremoteobjects-$(QT5_SOURCE_TARBALL_PREFIX)-$(QT5REMOTEOBJECTS_VERSION).tar.xz
> +QT5REMOTEOBJECTS_DEPENDENCIES = qt5base

$ find build/qt5remoteobjects-5.12.7 -name "*.pro" | xargs grep QT

build/qt5remoteobjects-5.12.7/src/imports/compat/compat.pro:QT += qml remoteobjects

--> at least an optional dependency is missing


> +QT5REMOTEOBJECTS_INSTALL_STAGING = YES
> +
> +ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y)
> +QT5REMOTEOBJECTS_LICENSE = GPL-2.0+ or LGPL-3.0, GPL-3.0 with
> exception(tools), GFDL-1.3 (docs)
> +QT5REMOTEOBJECTS_LICENSE_FILES = LICENSE.GPL2 LICENSE.GPL3
> LICENSE.GPL3-EXCEPT LICENSE.LGPL3 LICENSE.FDL
> +else
> +QT5REMOTEOBJECTS_LICENSE = GPL-2.0 or GPL-3.0 or LGPL-2.1 with
> exception or LGPL-3.0, GFDL-1.3 (docs)
> +QT5REMOTEOBJECTS_LICENSE_FILES = LICENSE.GPLv2 LICENSE.GPLv3
> LICENSE.LGPLv21 LGPL_EXCEPTION.txt LICENSE.LGPLv3 LICENSE.FDL
> +endif
> +
> +define QT5REMOTEOBJECTS_CONFIGURE_CMDS
> + (cd $(@D); $(TARGET_MAKE_ENV) $(HOST_DIR)/bin/qmake)
> +endef
> +
> +define QT5REMOTEOBJECTS_BUILD_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
> +endef
> +
> +define QT5REMOTEOBJECTS_INSTALL_STAGING_CMDS
> + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install
> +endef
> +
> +ifeq ($(BR2_STATIC_LIBS),)
> +define QT5REMOTEOBJECTS_INSTALL_TARGET_LIBS
> + cp -dpf $(STAGING_DIR)/usr/lib/libQt5RemoteObjects.so.*
> $(TARGET_DIR)/usr/lib
> +endef
> +endif
> +
> +ifeq ($(BR2_PACKAGE_QT5BASE_EXAMPLES),y)
> +define QT5REMOTEOBJECTS_INSTALL_TARGET_EXAMPLES
> + cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/remoteobjects
> $(TARGET_DIR)/usr/lib/qt/examples/
> +endef
> +endif
> +
> +define QT5REMOTEOBJECTS_INSTALL_TARGET_CMDS
> + $(QT5REMOTEOBJECTS_INSTALL_TARGET_LIBS)
> + $(QT5REMOTEOBJECTS_INSTALL_TARGET_EXAMPLES)
> +endef
> +
> +$(eval $(generic-package))
>

Otherwise looks good (and compiles)...

Regards,
Peter