[Buildroot] [PATCH] package/spidermonkey: do not build the JavaScript shell, by default

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Carlos,

On Sun, 8 Mar 2020 12:11:41 -0300
Carlos Santos <unixmania@gmail.com> wrote:

> > We already had a 0001 patch, we actually have 10 patches on
> > spidermonkey, so I renamed this one 0011.  
> 
> Hum, that's the price passing "1" instead of "11" to --start-number. :-(

Hehe :-)

> 
> > Has this patch been submitted upstream ?  
> 
> Well, "upstream" is Firefox and I don't believe they would care about
> an installation error when we compile a code sub-tree taken from a
> tarball made for Gentoo with an extra patch to force in-tree builds.
> ;-)

Indeed, there is not really a regular upstream for spidermonkey.
Fortunately, there are some patches submitting to polkit to make it use
the duktape JS engine instead of spidermonkey, hopefully they will be
merged in the near future.

> If the patch annoys you we can just use a post-install-target hook to
> remove js60. I didn't follow this approach because I was afraid that
> not passing --disable-js-shell would lead to the inclusion of code
> that could cause problem at run time.

Nah, the patch is fine, let's keep it this way.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com