From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/vlc: fix build with opencv3
Date: Sun, 8 Mar 2020 22:28:49 +0100 [thread overview]
Message-ID: <20200308222849.10e6d47d@windsurf.home> (raw)
In-Reply-To: <CAPi7W83cDsLz5jfZdOzL62QAJXNe-swYUOX+b4kiEvMYjexmYQ@mail.gmail.com>
Hello,
On Sun, 8 Mar 2020 16:49:07 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > Thanks for looking into this. I must say I don't feel very confident
> > about the fix. Have you been able to trace which change in OpenCV
> > caused this build issue ?
> The issue is raised by
> https://github.com/opencv/opencv/pull/11159/commits/7f9253ea0a9fe2635926379420002dbf0c3fce0f
> which changed the CV_RGB definition from cvScalar to cv::Scalar
> however cvRectangle was not updated and still waits for a CvScalar
> color.
> So, a better fix would be to remove the reference on CV_RGB and use
> directly cvScalar. I'll send a v2 if you agree that this is a better
> proposal.
I don't really know what is the right way of fixing this. Have you paid
attention to compatibility with OpenCV 2.x, if VLC can build with
OpenCV 2.x ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-03-08 21:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 13:38 [Buildroot] [PATCH 1/1] package/vlc: fix build with opencv3 Fabrice Fontaine
2020-03-08 14:42 ` Thomas Petazzoni
2020-03-08 15:49 ` Fabrice Fontaine
2020-03-08 21:28 ` Thomas Petazzoni [this message]
2020-03-08 22:17 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200308222849.10e6d47d@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox