Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/cog: add option for platform DRM.
Date: Tue, 10 Mar 2020 15:23:02 +0100	[thread overview]
Message-ID: <20200310152302.23f620ba@gmx.net> (raw)
In-Reply-To: <394e9ef0dfd8d15ed2dcae67a3cd8cece69993aa.camel@igalia.com>

Hello Charles,

On Tue, 10 Mar 2020 13:49:42 +0000, Charles Turner <cturner@igalia.com> wrote:

> Hi Peter,
>
> On Tue, 2020-03-10 at 13:36 +0100, Peter Seiderer wrote:
> > > diff --git a/package/cog/cog.mk b/package/cog/cog.mk
> > > index d0e5b79c38..0bbc684436 100644
> > > --- a/package/cog/cog.mk
> > > +++ b/package/cog/cog.mk
> > > @@ -8,13 +8,17 @@ COG_VERSION = 0.4.0
> > >  COG_SITE = https://wpewebkit.org/releases
> > >  COG_SOURCE = cog-$(COG_VERSION).tar.xz
> > >  COG_INSTALL_STAGING = YES
> > > -COG_DEPENDENCIES = dbus wpewebkit wpebackend-fdo
> > > +COG_DEPENDENCIES = dbus wayland wpewebkit wpebackend-fdo
> >
> > New option, unconditionally added new dependency on wayland?
>
> Perhaps I should place that in a separate patch. Cog does depend on
> wayland with wpewebkit, which is why I reflex-added it to the deps.
> It's already depended on from the wpewebkit dependency, but I didn't
> like relying on a separate packages dependency list for this package,
> especially when Cog can be build with webkitgtk instead, in which case
> it would not need the wayland dep (although I wonder if anyone has
> tested that in buildroot yet :-))

Thanks for explanation...

>
> From this reasoning, I will remove this added dependency on wayland.
>
> >
> > >  COG_LICENSE = MIT
> > >  COG_LICENSE_FILES = COPYING
> > >  COG_CONF_OPTS = \
> > >  	-DCOG_BUILD_PROGRAMS=ON \
> > >  	-DCOG_PLATFORM_FDO=ON \
> > > -	-DCOG_PLATFORM_DRM=OFF \
> > >  	-DCOG_HOME_URI='$(call
> > > qstrip,$(BR2_PACKAGE_COG_PROGRAMS_HOME_URI))'
> > >
> > > +ifeq ($(BR2_PACKAGE_COG_PLATFORM_DRM),y)
> > > +	COG_CONF_OPTS += -DCOG_PLATFORM_DRM=ON
> > > +	COG_DEPENDENCIES += libdrm libinput
> >
> > missing:
> >
> > #else
> > 	COG_CONF_OPTS += -DCOG_PLATFORM_DRM=OFF
>
> This is default off in CMake, which is why I removed it from the .mk
> file here.

Defaults can change, explicit setting preferred ;-)

Regards,
Peter

>
> B.R
> 	Charlie.
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

  reply	other threads:[~2020-03-10 14:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10 11:22 [Buildroot] [PATCH 1/2] package/cog: add option for platform DRM Charlie Turner
2020-03-10 11:22 ` [Buildroot] [PATCH 2/2] board/raspberrypi: add post-image option for VC4 overlay Charlie Turner
2020-03-10 12:58   ` Peter Seiderer
2020-03-10 13:42     ` Charles Turner
2020-03-10 12:36 ` [Buildroot] [PATCH 1/2] package/cog: add option for platform DRM Peter Seiderer
2020-03-10 13:49   ` Charles Turner
2020-03-10 14:23     ` Peter Seiderer [this message]
2020-03-11 10:30 ` [Buildroot] [PATCH v2 1/1] " Charlie Turner
2020-03-11 12:49   ` Adrian Perez de Castro
2020-03-12 11:03   ` Thomas Petazzoni
2020-03-12 13:11     ` Charles Turner
2020-03-12 13:36       ` Thomas Petazzoni
2020-03-12 19:36         ` Charles Turner
2020-03-12 19:47   ` [Buildroot] [PATCH v3 " Charlie Turner
2020-03-23 13:30     ` Charles Turner
2020-03-31 21:57     ` Adrian Perez de Castro
2020-04-02 11:34     ` [Buildroot] [PATCH v4] " Charlie Turner
2020-04-04 21:46       ` Thomas Petazzoni
2020-04-04 22:49         ` Adrian Perez de Castro
2020-04-06  5:29           ` Thomas Petazzoni
2020-04-06 17:04           ` Charles Turner
2020-04-06 17:18             ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200310152302.23f620ba@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox