Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next v2 3/4] package/openrc: add libselinux support
Date: Wed, 11 Mar 2020 18:35:42 +0100	[thread overview]
Message-ID: <20200311173542.GO5357@scaer> (raw)
In-Reply-To: <20200311172623.GN5357@scaer>

CArlos, Adam, All,

On 2020-03-11 18:26 +0100, Yann E. MORIN spake thusly:
> On 2020-03-01 12:17 -0300, unixmania at gmail.com spake thusly:
> > From: Adam Duskett <Aduskett@gmail.com>
> > If the libselinux package is selected, add the package to the dependency list
> > and explicitly set OPENRC_MAKE_OPTS += MKSELINUX=yes
> 
> This SELinux stuff has always been a bit boo-I-dont-want-too-touch for
> me, because it looks overly complex, so just adding the dependency
> without explanations on how openrc uses/fits with SELinux is a bit too
> much for me to handle, so I defer to a SELinux-knowledgeable maintainer
> to look a it...

WHAT I forgot to say above the current commit log, is that it is not
that helpful: it just repeats in english what the patch does, which is
anyway already pretty trivial to see... What a commit log should say, is
why the patch exists, and how the patch works.

Totally hypotetical commit log:

    package/openrc: add libselinux support

    OpenRC has suport for SELinux contexts, but we currently forcibly
    disable it.

    When SELinux is enabled, we know a policy will be installed, so we
    can enable SELinux support in OpenRC.

    Signed-off-by: you
    Signed-off-by: the other

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-03-11 17:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-01 15:17 [Buildroot] [PATCH/next v2 0/4] openrc: bump to version 0.42.1 unixmania at gmail.com
2020-03-01 15:17 ` [Buildroot] [PATCH/next v2 1/4] package/openrc: drop custom getty service unixmania at gmail.com
2020-03-11 16:52   ` Yann E. MORIN
2020-03-11 17:04     ` Carlos Santos
2020-03-01 15:17 ` [Buildroot] [PATCH/next v2 2/4] package/openrc: bump to version 0.42.1 unixmania at gmail.com
2020-03-11 17:22   ` Yann E. MORIN
2020-03-12  2:03     ` Carlos Santos
2020-03-01 15:17 ` [Buildroot] [PATCH/next v2 3/4] package/openrc: add libselinux support unixmania at gmail.com
2020-03-11 17:26   ` Yann E. MORIN
2020-03-11 17:35     ` Yann E. MORIN [this message]
2020-04-16  2:41       ` Carlos Santos
2020-04-16  2:20     ` Carlos Santos
2020-03-01 15:17 ` [Buildroot] [PATCH/next v2 4/4] support/testing: add openrc tests unixmania at gmail.com
2020-03-01 17:39   ` Yann E. MORIN
2020-03-03 11:59     ` Carlos Santos
2020-03-11 17:50   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200311173542.GO5357@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox