From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sun, 15 Mar 2020 16:30:27 +0100 Subject: [Buildroot] [PATCH 2/3] package/automake: also include autoconf-archive in search paths In-Reply-To: <20200210142721.3390d716@windsurf> References: <20200210142721.3390d716@windsurf> Message-ID: <20200315163027.03f63f78@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Mon, 10 Feb 2020 14:27:21 +0100 Thomas Petazzoni wrote: > On Sun, 9 Feb 2020 16:12:41 +0100 > "Yann E. MORIN" wrote: > > > diff --git a/package/automake/automake.mk b/package/automake/automake.mk > > index 89dcaa1293..238116cb94 100644 > > --- a/package/automake/automake.mk > > +++ b/package/automake/automake.mk > > @@ -33,5 +33,11 @@ $(eval $(host-autotools-package)) > > AUTOMAKE = $(HOST_DIR)/bin/automake > > ACLOCAL_DIR = $(STAGING_DIR)/usr/share/aclocal > > ACLOCAL = $(HOST_DIR)/bin/aclocal > > -ACLOCAL_PATH = $(ACLOCAL_DIR):$(ACLOCAL_HOST_DIR) > > +ACLOCAL_PATH = $(subst $(space),:,$(strip \ > > + $(ACLOCAL_DIR) \ > > + $(ACLOCAL_HOST_DIR) \ > > + $(if $(filter host-autoconf-archive,$($(PKG)_FINAL_ALL_DEPENDENCIES)),\ > > + $(HOST_DIR)/share/autoconf-archive \ > > + ) \ > > +)) > > Meh :-/ Can we add something more explicit than that in the > infrastructure? Poking around in the package dependencies like this to > second guess which path should be added to ACLOCAL_PATH is not really > great :-/ So I've marked PATCH 2/3 and 3/3 as Rejected. We fixed the sdbusplus issue by re-adding the hook creating the m4 directory. I understand the idea of having more "automatic", but this approach of looking at the dependencies of the package felt really odd. We can always revisit this of course. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com