From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yann E. MORIN <yann.morin.1998@free.fr>
Date: Sun, 15 Mar 2020 22:10:18 +0100
Subject: [Buildroot] [PATCH 1/1] package/rdesktop: use --with-sound
 option
In-Reply-To: <20200315220704.4d588598@windsurf>
References: <20200314223641.2552635-1-fontaine.fabrice@gmail.com>
 <20200315220704.4d588598@windsurf>
Message-ID: <20200315211018.GK19677@scaer>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Fabrice, Thomas, All,

On 2020-03-15 22:07 +0100, Thomas Petazzoni spake thusly:
> On Sat, 14 Mar 2020 23:36:41 +0100
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> 
> > Use --with-sound option as requested by Thomas Petazzoni in review of
> > https://patchwork.ozlabs.org/patch/1254693
> > 
> > alsa, libao and pulseaudio are not exclusive, the order of registrations
> > in rdpsnd_register_drivers define the probe-order when opening the
> > device for the first time
> 
> But if you pass a single --with-sound=foo, don't they become mutually
> exclusive ? Does the configure script properly handles --with-sound=foo
> --with-sound=bar, and understands it should enable both support for
> "foo" and "bar" ? I think a normal configure script would only keep
> "bar" in such a circumstance.

Which is indeed what happens here;

    https://github.com/rdesktop/rdesktop/blob/master/configure.ac#L286

Regards,
Yann E. MORIN.

> Best regards,
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'