Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v6 1/2] package/netdata: new package
Date: Tue, 24 Mar 2020 22:34:51 +0100	[thread overview]
Message-ID: <20200324223451.529ca95c@windsurf.home> (raw)
In-Reply-To: <20200320152517.3108669-1-m.niestroj@grinn-global.com>

Hello Marcin,

On Fri, 20 Mar 2020 16:25:16 +0100
Marcin Niestroj <m.niestroj@grinn-global.com> wrote:

> Always provide --disable-dbengine configuration option, because we do
> not support libjudy dependency that is required otherwise.
> 
> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>

Thanks, I've applied to master, with some small changes. See below.

> +# Create needed directories.
> +[ -d "/var/cache/$DAEMON" ] || mkdir -p "/var/cache/$DAEMON"
> +[ -d "/var/lib/$DAEMON" ] || mkdir -p "/var/lib/$DAEMON"
> +[ -d "/var/log/$DAEMON" ] || mkdir -p "/var/log/$DAEMON"

I've simplified to just

mkdir -p /var/cache/$DAEMON /var/lib/$DAEMON /var/log/$DAEMON

indeed, there's no need to test before doing mkdir -p, mkdir -p will
exit successfully if the folder already exists.

> +NETDATA_VERSION = 1.20.0
> +NETDATA_SITE = $(call github,netdata,netdata,v$(NETDATA_VERSION))
> +NETDATA_LICENSE = GPL-3.0

The license really is GPL-3.0+.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2020-03-24 21:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20 15:25 [Buildroot] [PATCH v6 1/2] package/netdata: new package Marcin Niestroj
2020-03-20 15:25 ` [Buildroot] [PATCH v6 2/2] support/testing: add netdata test Marcin Niestroj
2020-03-24 21:34   ` Thomas Petazzoni
2020-03-24 21:34 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200324223451.529ca95c@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox