Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 2/7] package/vala: install wrapper to vapigen
Date: Sun, 29 Mar 2020 17:13:39 +0200	[thread overview]
Message-ID: <20200329151339.GG22325@scaer> (raw)
In-Reply-To: <20200327183000.1005676-2-aduskett@gmail.com>

On 2020-03-27 11:29 -0700, aduskett at gmail.com spake thusly:
> From: Adam Duskett <Aduskett@gmail.com>
> 
> when compiling gobject-introspection .gir files, some packages use vapigen to
> generate a vala-api compatible .gir file. These packages tend to call vapigen
> directly instead of vala or valac.
> 
> Without the wrapper, building the .gir files fail. In the case of for example,
> gupnp-dlna throws the following error:
> "error: Package `Gst-1.0' not found in specified Vala API directories or
> GObject-Introspection GIR directories."
> 
> Installing the vala wrapper to vapigen fixes the above issue.
> 
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>

Applied to master with very minor tweaks in the commit log. Thanks!

I  haven't applied the rest of the series for now; I've left it pending
while I think about it...

Regards,
Yann E. MORIN.

> ---
> Changes v2 -> v3:
>   - Add $(HOST_DIR)/bin/vapigen to the sed line.
> 
>  package/vala/vala.mk | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/package/vala/vala.mk b/package/vala/vala.mk
> index b8a69f8c5e..95365faf18 100644
> --- a/package/vala/vala.mk
> +++ b/package/vala/vala.mk
> @@ -17,16 +17,19 @@ HOST_VALA_DEPENDENCIES = host-bison host-flex host-libglib2
>  HOST_VALA_CONF_ENV = ac_cv_path_XSLTPROC=:
>  HOST_VALA_CONF_OPTS += --disable-valadoc
>  
> -# We wrap vala & valac to point to the proper gir and vapi data dirs
> +# We wrap vala, valac and vapigen to point to the proper gir and vapi data dirs
>  # Otherwise we'll get host directory data which isn't enough
>  define HOST_VALA_INSTALL_WRAPPER
>  	$(INSTALL) -D -m 0755 package/vala/vala-wrapper \
>  		$(HOST_DIR)/bin/vala
>  	$(INSTALL) -D -m 0755 package/vala/vala-wrapper \
>  		$(HOST_DIR)/bin/valac
> +	$(INSTALL) -D -m 0755 package/vala/vala-wrapper \
> +		$(HOST_DIR)/bin/vapigen
>  	$(SED) 's, at VALA_VERSION@,$(VALA_VERSION_MAJOR),' \
>  		$(HOST_DIR)/bin/vala \
> -		$(HOST_DIR)/bin/valac
> +		$(HOST_DIR)/bin/valac \
> +		$(HOST_DIR)/bin/vapigen
>  endef
>  HOST_VALA_POST_INSTALL_HOOKS += HOST_VALA_INSTALL_WRAPPER
>  
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-03-29 15:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27 18:29 [Buildroot] [PATCH v3 1/7] package/vala/vala-wrapper: fix wrapper aduskett at gmail.com
2020-03-27 18:29 ` [Buildroot] [PATCH v3 2/7] package/vala: install wrapper to vapigen aduskett at gmail.com
2020-03-29 15:13   ` Yann E. MORIN [this message]
2020-03-27 18:29 ` [Buildroot] [PATCH v3 3/7] package/gssdp: enable vala support if gobject-introspection is selected aduskett at gmail.com
2020-03-31 21:16   ` Yann E. MORIN
2020-03-27 18:29 ` [Buildroot] [PATCH v3 4/7] package/gssdp: bump version to 1.2.2 aduskett at gmail.com
2020-03-29 19:52   ` Yann E. MORIN
2020-03-27 18:29 ` [Buildroot] [PATCH v3 5/7] package/gupnp: " aduskett at gmail.com
2020-03-27 18:29 ` [Buildroot] [PATCH v3 6/7] package/gupnp: Depend on host-vala if gobject-introspection is selected aduskett at gmail.com
2020-03-31 21:17   ` Yann E. MORIN
2020-03-27 18:30 ` [Buildroot] [PATCH v3 7/7] package/gupnp-dlna: add optional dependency for gobject-introspection aduskett at gmail.com
2020-03-29 20:42   ` Yann E. MORIN
2020-04-06 20:38     ` Thomas Petazzoni
2020-04-06 20:49       ` Yann E. MORIN
2020-03-29 14:50 ` [Buildroot] [PATCH v3 1/7] package/vala/vala-wrapper: fix wrapper Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200329151339.GG22325@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox