From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 2 Apr 2020 16:25:43 +0200 Subject: [Buildroot] [PATCH 2/2] package/freescale-imx/imx-gpu-viv: fix build issue with Wayland backend In-Reply-To: <20200402130842.918696-3-gary.bisson@boundarydevices.com> References: <20200402130842.918696-1-gary.bisson@boundarydevices.com> <20200402130842.918696-3-gary.bisson@boundarydevices.com> Message-ID: <20200402162543.595ed9e7@windsurf.home> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Gary, As usual, thanks for your work maintaining good support for i.MX platforms in Buildroot. One question below. On Thu, 2 Apr 2020 15:08:42 +0200 Gary Bisson wrote: > ifeq ($(IMX_GPU_VIV_LIB_TARGET),fb) > -define IMX_GPU_VIV_FIXUP_FB_HEADERS > +define IMX_GPU_VIV_FIXUP_HEADERS > $(SED) '39i\ > - #if !defined(EGL_API_X11) && !defined(EGL_API_DFB) && !defined(EGL_API_FB) \n\ > + #if !defined(EGL_API_X11) && !defined(EGL_API_DFB) && !defined(EGL_API_FB) && !defined(WL_EGL_PLATFORM) \n\ > #define EGL_API_FB \n\ > #endif' $(STAGING_DIR)/usr/include/EGL/eglplatform.h > endef > @@ -77,6 +77,12 @@ ifeq ($(IMX_GPU_VIV_LIB_TARGET),wl) > define IMX_GPU_VIV_FIXUP_PKGCONFIG > ln -sf egl_wayland.pc $(@D)/gpu-core/usr/lib/pkgconfig/egl.pc > endef > +define IMX_GPU_VIV_FIXUP_HEADERS > + $(SED) '39i\ > + #if !defined(EGL_API_X11) && !defined(EGL_API_DFB) && !defined(EGL_API_FB) && !defined(WL_EGL_PLATFORM) \n\ > + #define WL_EGL_PLATFORM\n\ > + #endif' $(STAGING_DIR)/usr/include/EGL/eglplatform.h > +endef > endif Can we use a proper patch instead of these horrible SED calls ? Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com