Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] support/testing: update the ARM toolchain used for the systemd init tests
Date: Sun, 5 Apr 2020 11:09:13 +0200	[thread overview]
Message-ID: <20200405090913.GK22325@scaer> (raw)
In-Reply-To: <20200405084428.GJ22325@scaer>

Romain, All,

On 2020-04-05 10:44 +0200, Yann E. MORIN spake thusly:
> On 2020-04-05 00:02 +0200, Romain Naour spake thusly:
> > As reported on the mailing list, there is a build issue with systemd 245
> > when using gcc < 5.0:
> > http://lists.busybox.net/pipermail/buildroot/2020-April/278931.html
[--SNIP--]
> >          BR2_TOOLCHAIN_EXTERNAL=y
> > +        BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
> > +        BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
> > +        BR2_TOOLCHAIN_EXTERNAL_URL="http://toolchains.bootlin.com/downloads/releases/toolchains/armv5-eabi--glibc--stable-2017.05-toolchains-1-1.tar.bz2"
> I'd rather we use one of the known pre-built toolchains that is
> available from the menuconfig. Unfortiunately, for armv5, we have no
> better than the codesourcery one. But for armv7, we have a darn-recent
> toolchain from ARM.

Of course, I mistakenly replied to your v1 of your patchset, but this is
also valid for your v2...

Regards,
Yann E. MORIN.

> So I think we just need to add BR2_cortex_a7 to this defconfig:
> 
>     diff --git a/support/testing/tests/init/test_systemd.py b/support/testing/tests/init/test_systemd.py
>     index 0ac18cb623..d679081768 100644
>     --- a/support/testing/tests/init/test_systemd.py
>     +++ b/support/testing/tests/init/test_systemd.py
>     @@ -6,6 +6,7 @@ class InitSystemSystemdBase(InitSystemBase):
>          config = \
>              """
>              BR2_arm=y
>     +        BR2_cortex_a7=y
>              BR2_TOOLCHAIN_EXTERNAL=y
>              BR2_INIT_SYSTEMD=y
>              BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
> 
> Note that I am not saying the bootlin toolchains are bad. I am instead
> saying that we should test with what is readily available in menuconfig,
> so that we know users can have a working starting point.
> 
> Runtime tests are not (IMHO) about testing corner cases, but to ensure
> that the packages do build and run as expected in standard conditions.
> 
> Bootlin toolchains are not in the menuconfig, while the ARM toolchain
> is, and that is what users will use 99.99% of the time. Hence we should
> test with that.
> 
> Regards,
> Yann E. MORIN.
> 
> > +        BR2_TOOLCHAIN_EXTERNAL_GCC_5=y
> > +        BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_10=y
> > +        BR2_TOOLCHAIN_EXTERNAL_HAS_SSP=y
> > +        BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC=y
> >          BR2_INIT_SYSTEMD=y
> >          BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
> >          BR2_LINUX_KERNEL=y
> > -- 
> > 2.25.1
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2020-04-05  9:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-04 22:02 [Buildroot] [PATCH 1/2] support/testing: update the ARM toolchain used for the systemd init tests Romain Naour
2020-04-04 22:02 ` [Buildroot] [PATCH 2/2] package/systemd: add gcc >= 5.x dependency Romain Naour
2020-04-05  8:44 ` [Buildroot] [PATCH 1/2] support/testing: update the ARM toolchain used for the systemd init tests Yann E. MORIN
2020-04-05  9:09   ` Yann E. MORIN [this message]
2020-04-05  9:35     ` Romain Naour
2020-04-05  9:54       ` Yann E. MORIN
2020-04-05 10:04         ` Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200405090913.GK22325@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox